linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Russell King <rmk+kernel@armlinux.org.uk>
Subject: [PATCH 0/2] ASoC: hdmi-codec: fix locking issue
Date: Wed, 23 Oct 2019 18:12:01 +0200	[thread overview]
Message-ID: <20191023161203.28955-1-jbrunet@baylibre.com> (raw)

This patchset fixes the locking issue reported by Russell.

As explained a mutex was used as flag and held while returning to
userspace.

Patch 2 is entirely optional and switches from bit atomic operation
to mutex again. I tend to prefer bit atomic operation in this
particular case but either way should be fine.

Jerome Brunet (2):
  Revert "ASoC: hdmi-codec: re-introduce mutex locking"
  ASoC: hdmi-codec: re-introduce mutex locking again

 sound/soc/codecs/hdmi-codec.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

-- 
2.21.0


             reply	other threads:[~2019-10-23 16:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 16:12 Jerome Brunet [this message]
2019-10-23 16:12 ` [PATCH 1/2] Revert "ASoC: hdmi-codec: re-introduce mutex locking" Jerome Brunet
2019-10-23 16:37   ` Mark Brown
2019-10-23 18:26     ` Russell King - ARM Linux admin
2019-10-23 18:46       ` Mark Brown
2019-10-23 18:56   ` Applied "ASoC: hdmi-codec: drop mutex locking again" to the asoc tree Mark Brown
2019-10-23 16:12 ` [PATCH 2/2] ASoC: hdmi-codec: re-introduce mutex locking again Jerome Brunet
2019-10-23 16:23 ` [alsa-devel] [PATCH 0/2] ASoC: hdmi-codec: fix locking issue Takashi Iwai
2019-10-23 17:53   ` Jerome Brunet
2019-10-24 11:34     ` Mark Brown
2019-10-24 12:15       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023161203.28955-1-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).