linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Helge Deller <deller@gmx.de>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-parisc@vger.kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: hp_sdc_rtc - remove dead chardev code
Date: Wed, 23 Oct 2019 13:38:55 -0700	[thread overview]
Message-ID: <20191023203855.GZ35946@dtor-ws> (raw)
In-Reply-To: <50a48356-294d-516d-6448-ee06273fd014@gmx.de>

On Wed, Oct 23, 2019 at 09:06:29PM +0200, Helge Deller wrote:
> On 23.10.19 17:22, Alexandre Belloni wrote:
> > On 23/10/2019 16:25:02+0200, Arnd Bergmann wrote:
> > > The driver contains half of the implementation of /dev/rtc, but this
> > > was never completed, and it is now incompatible with the drivers/rtc
> > > framework.
> > > 
> > > Remove the chardev completely. If anyone wants to add the functionality
> > > later, that shoudl be done through rtc_register_device().
> > > 
> > > The remaining portions of the driver basically implement a single
> > > procfs file that may or may not be used anywhere. Not sure why this
> > > is in drivers/input/ though.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> A year ago I did actually converted this driver to the RTC framework.
> But after some testing on my physical box (a 715/64 PA-RISC machine
> with HIL connector) I realized that the SDC in that machine doesn't
> provide a functional RTC, and even more important, on that box we don't
> need this RTC because the system provides a built-in RTC on-mainboard instead.
> So, I never pushed my changes upstream, which can still be found here:
> https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=hp_sdc_rtc_conversion&id=0d4250dbcfa2bb8b326ce7721e19e10a66f1eb92
> 
> So, I don't think any PA-RISC machine needs this driver, and as such
> I'm happy to give my:
> Acked-by: Helge Deller <deller@gmx.de>

Applied, thank you.

> 
> I even think the whole driver can go away...
> 
> Helge
> 
> PS: Maybe some really old 68000-based HP machines needed that, but
> I don't know if any recent Linux kernel runs on those old boxes any
> longer...

Well, if you think it is unlikely that we need this driver just send me
a patch. We can always restore it if someone yells.

Thanks.

-- 
Dmitry

  reply	other threads:[~2019-10-23 20:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 14:25 [PATCH] Input: hp_sdc_rtc - remove dead chardev code Arnd Bergmann
2019-10-23 15:22 ` Alexandre Belloni
2019-10-23 19:06   ` Helge Deller
2019-10-23 20:38     ` Dmitry Torokhov [this message]
2019-11-14  9:46     ` Geert Uytterhoeven
2019-11-14  9:46       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023203855.GZ35946@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=deller@gmx.de \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).