From: Keith Busch <kbusch@kernel.org>
To: Olof Johansson <olof@lixom.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Keith Busch <keith.busch@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/DPC: Add pcie_ports=dpc-native parameter to bring back old behavior
Date: Thu, 24 Oct 2019 11:37:04 +0900 [thread overview]
Message-ID: <20191024023704.GA3152@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20191023192205.97024-1-olof@lixom.net>
On Wed, Oct 23, 2019 at 12:22:05PM -0700, Olof Johansson wrote:
> In commit eed85ff4c0da7 ("PCI/DPC: Enable DPC only if AER is available"),
> the behavior was changed such that native (kernel) handling of DPC
> got tied to whether the kernel also handled AER. While this is what
> the standard recommends, there are BIOSes out there that lack the DPC
> handling since it was never required in the past.
>
> To make DPC still work on said platforms the same way they did before,
> add a "pcie_ports=dpc-native" kernel parameter that can be passed in
> if needed, while keeping defaults unchanged.
If platform firmware wants to handle AER events, but the kernel enables
the DPC capability, the ports will be trapping events that firmware is
expecting to handle. Not that that's a bad thing: firmware is generally
worse at handling these errors.
> +/*
> + * If the user specified "pcie_ports=dpc-native", use the PCIe services
> + * for DPC, but cuse platform defaults for the others.
s/cuse/use
> @@ -1534,9 +1534,11 @@ static inline int pci_irqd_intx_xlate(struct irq_domain *d,
> #ifdef CONFIG_PCIEPORTBUS
> extern bool pcie_ports_disabled;
> extern bool pcie_ports_native;
> +extern bool pcie_ports_dpc_native;
> #else
> #define pcie_ports_disabled true
> #define pcie_ports_native false
> +#define pcie_ports_dpc_native false
> #endif
You do not have any references to pcie_ports_dpc_native outside of files that
require CONFIG_PCIEPORTBUS, so no need to define a default.
next prev parent reply other threads:[~2019-10-24 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 19:22 [PATCH] PCI/DPC: Add pcie_ports=dpc-native parameter to bring back old behavior Olof Johansson
2019-10-24 2:37 ` Keith Busch [this message]
2019-10-24 3:45 ` Olof Johansson
2019-10-25 20:20 ` Bjorn Helgaas
2019-11-07 19:59 ` Kuppuswamy Sathyanarayanan
2019-11-07 20:09 ` Olof Johansson
2019-11-07 22:05 ` Kuppuswamy Sathyanarayanan
2019-11-07 23:59 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024023704.GA3152@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).