From: Jiri Olsa <jolsa@redhat.com>
To: Igor Lubashev <ilubashe@akamai.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] perf: Allow running without stdin
Date: Thu, 24 Oct 2019 10:24:01 +0200 [thread overview]
Message-ID: <20191024082401.GA13378@krava> (raw)
In-Reply-To: <1571795693-23558-1-git-send-email-ilubashe@akamai.com>
On Tue, Oct 22, 2019 at 09:54:50PM -0400, Igor Lubashev wrote:
> This series allows perf to run in batch mode with stdin closed.
> This is arguably a bug fix for code that runs with --stdio option and does not
> check for EOF return code from getc().
>
> This series makes the following work as expected:
>
> $ perf top --stdio < /dev/null
> $ perf kvm top --stdio < /dev/null
>
> Patches:
> 01: perf top: Allow running without stdin
> Make "perf top --stdio" handle EOF from stdin correctly.
> There is one getc() that does not handle EOF explicitly, since its return
> value is checked against a list of known characters, and the main loop in
> display_thread() will handle the EOF on the next iteration.
>
> 02: perf kvm: Allow running without stdin
> Make "perf kvm --stdio" handle EOF from stdin correctly.
>
> 03: perf kvm: Use evlist layer api when possible
> This is a simple fix for a needless layering violation.
>
> Igor Lubashev (3):
> perf top: Allow running without stdin
> perf kvm: Allow running without stdin
> perf kvm: Use evlist layer api when possible
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> tools/perf/builtin-kvm.c | 35 +++++++++++++++++++++--------------
> tools/perf/builtin-top.c | 10 ++++++++--
> 2 files changed, 29 insertions(+), 16 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2019-10-24 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 1:54 [PATCH 0/3] perf: Allow running without stdin Igor Lubashev
2019-10-23 1:54 ` [PATCH 1/3] perf top: " Igor Lubashev
2019-10-23 1:54 ` [PATCH 2/3] perf kvm: " Igor Lubashev
2019-10-23 10:42 ` Jiri Olsa
2019-10-23 16:06 ` Lubashev, Igor
2019-11-08 19:55 ` Lubashev, Igor
2019-10-23 1:54 ` [PATCH 3/3] perf kvm: Use evlist layer api when possible Igor Lubashev
2019-10-23 12:58 ` Arnaldo Carvalho de Melo
2019-11-12 11:18 ` [tip: perf/core] " tip-bot2 for Igor Lubashev
2019-10-24 8:24 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024082401.GA13378@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ilubashe@akamai.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).