From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C809CA9EAF for ; Thu, 24 Oct 2019 18:55:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E448D21925 for ; Thu, 24 Oct 2019 18:55:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="gmYZ0ZzX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504183AbfJXSz5 (ORCPT ); Thu, 24 Oct 2019 14:55:57 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35669 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504162AbfJXSz5 (ORCPT ); Thu, 24 Oct 2019 14:55:57 -0400 Received: by mail-pg1-f194.google.com with SMTP id c8so9961601pgb.2 for ; Thu, 24 Oct 2019 11:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=skkWOjQAG2SIq7AkesQ7N9Msme6HEgCnl64zvN/Bfgc=; b=gmYZ0ZzXFAhIzSn0RsC3E5IY9lO/5YCbqiPHNi32xz8spoK5ic6ykYwFs1FYgYuyey gcSBD2gT0zJ1ONk5m3kGX9BkihBtmDZR4zhv5qJiFZj1KzesHfIkvdeP6G307k4UHrXQ qBwTje3AIyhk8WyJSj1jfRQe9piFiiOHMYH+CHsV7T6zT9HkiC4oXZ/kz7QrHnTjlfhE AnkKJRz+42vz1bkIJy3aohf+CuTT4SvjlNPEv/xMgRLUoRapXBcEzKpinlezFcT//pBX L6NJoY5ibeSgSWkaZteYUoq7L0OCQAxdzPbYdrfXI6doMjJ1z8oxwrf4TYsG08t6/nte qLFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=skkWOjQAG2SIq7AkesQ7N9Msme6HEgCnl64zvN/Bfgc=; b=KMClt0K8z3FV23+0jnar0VxGaXqB1nIIf7uNGlnPw6vHpJQCJR5quB60rSwKswQ7+3 RJYOHlmosqvCa8NgAuwM9i+J13lVQ4thMDrknDd1Hb62FW49c09Zi7zZFve5QiN43mbi cD826VBWJl7InpCtqJ4zus+9/xHZy8QVZd6fKDcEoL4dJeJ+GFjDu+Zq7xF9rPT1lk+d U4fXYIFRSGweKfc1wq0qmVkGAprSXtitUWVh+MrIKf2/6rNPCwp7vbTUNX8Lq2oiKkwv IL2nVmAjQ+bAOhV9moYMbDc9Rw4HdSPtTv0mH4kWdMn1JcA3uOUQBjVSaT1ld6NXA47Y Ribw== X-Gm-Message-State: APjAAAVYIM2yLssxc/gtL6fY/IX7CjvJtYjb3I08RUwFfJ3pSr9g2Ku+ usyxxmJkN0R0CqWCgyDZl006cw== X-Google-Smtp-Source: APXvYqxkPjWyobL7PL4g3GBnG5LW/qPP3xnmD7I0AhT6krKXNPb0Dyo+2MgK0FL0VIAnXgtEOx6Xsg== X-Received: by 2002:a63:9208:: with SMTP id o8mr18075167pgd.256.1571943356385; Thu, 24 Oct 2019 11:55:56 -0700 (PDT) Received: from cakuba.hsd1.ca.comcast.net (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id f25sm9448405pfk.10.2019.10.24.11.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 11:55:56 -0700 (PDT) Date: Thu, 24 Oct 2019 11:55:53 -0700 From: Jakub Kicinski To: Sheetal Tigadoli Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Greg Kroah-Hartman , Michal Simek , Rajan Vaja , Scott Branden , Ray Jui , Vikram Prakash , Jens Wiklander , Michael Chan , "David S. Miller" , Vikas Gupta , Vasundhara Volam , Linux Kernel Mailing List , tee-dev@lists.linaro.org, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org Subject: Re: [PATCH V3 3/3] bnxt_en: Add support to collect crash dump via ethtool Message-ID: <20191024115553.11a6f4be@cakuba.hsd1.ca.comcast.net> In-Reply-To: <1571895161-26487-4-git-send-email-sheetal.tigadoli@broadcom.com> References: <1571895161-26487-1-git-send-email-sheetal.tigadoli@broadcom.com> <1571895161-26487-4-git-send-email-sheetal.tigadoli@broadcom.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Oct 2019 11:02:41 +0530, Sheetal Tigadoli wrote: > From: Vasundhara Volam > > Driver supports 2 types of core dumps. > > 1. Live dump - Firmware dump when system is up and running. > 2. Crash dump - Dump which is collected during firmware crash > that can be retrieved after recovery. > Crash dump is currently supported only on specific 58800 chips > which can be retrieved using OP-TEE API only, as firmware cannot > access this region directly. > > User needs to set the dump flag using following command before > initiating the dump collection: > > $ ethtool -W|--set-dump eth0 N > > Where N is "0" for live dump and "1" for crash dump > > Command to collect the dump after setting the flag: > > $ ethtool -w eth0 data Filename > > v3: Modify set_dump to support even when CONFIG_TEE_BNXT_FW=n. > Also change log message to netdev_info(). > > Cc: Jakub Kicinski > Cc: Michael Chan > Signed-off-by: Vasundhara Volam > Signed-off-by: Sheetal Tigadoli Acked-by: Jakub Kicinski