linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] Enable stm32_pwr regulator driver for stm32mp157
@ 2019-10-24 15:41 Pascal Paillet
  2019-10-24 15:41 ` [PATCH 1/1] regulator: stm32_pwr: Enable " Pascal Paillet
  2019-10-24 19:31 ` [PATCH 0/1] Enable stm32_pwr regulator " Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Pascal Paillet @ 2019-10-24 15:41 UTC (permalink / raw)
  To: lgirdwood, broonie, linux-kernel; +Cc: p.paillet, linux-stm32

Enable the STM32 PWR regulator driver for stm32mp157 machine.

Pascal Paillet (1):
  regulator: stm32_pwr: Enable driver for stm32mp157

 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] regulator: stm32_pwr: Enable driver for stm32mp157
  2019-10-24 15:41 [PATCH 0/1] Enable stm32_pwr regulator driver for stm32mp157 Pascal Paillet
@ 2019-10-24 15:41 ` Pascal Paillet
  2019-10-24 19:31   ` Mark Brown
  2019-10-24 19:31 ` [PATCH 0/1] Enable stm32_pwr regulator " Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Pascal Paillet @ 2019-10-24 15:41 UTC (permalink / raw)
  To: lgirdwood, broonie, linux-kernel; +Cc: p.paillet, linux-stm32

Enable stm32 pwr regulators for stm32mp157 machine.

Signed-off-by: Pascal Paillet <p.paillet@st.com>
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 3ee63531f6d5..ed10f4f46fdf 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -875,6 +875,7 @@ config REGULATOR_STM32_VREFBUF
 config REGULATOR_STM32_PWR
 	bool "STMicroelectronics STM32 PWR"
 	depends on ARCH_STM32 || COMPILE_TEST
+	default MACH_STM32MP157
 	help
 	  This driver supports internal regulators (1V1, 1V8, 3V3) in the
 	  STMicroelectronics STM32 chips.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] regulator: stm32_pwr: Enable driver for stm32mp157
  2019-10-24 15:41 ` [PATCH 1/1] regulator: stm32_pwr: Enable " Pascal Paillet
@ 2019-10-24 19:31   ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-10-24 19:31 UTC (permalink / raw)
  To: Pascal Paillet; +Cc: lgirdwood, linux-kernel, linux-stm32

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

On Thu, Oct 24, 2019 at 05:41:21PM +0200, Pascal Paillet wrote:

> @@ -875,6 +875,7 @@ config REGULATOR_STM32_VREFBUF
>  config REGULATOR_STM32_PWR
>  	bool "STMicroelectronics STM32 PWR"
>  	depends on ARCH_STM32 || COMPILE_TEST
> +	default MACH_STM32MP157
>  	help

This isn't the sort of stuff we usually put in Kconfig, we usually just
leave it in the defconfig - why do things differently here?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/1] Enable stm32_pwr regulator driver for stm32mp157
  2019-10-24 15:41 [PATCH 0/1] Enable stm32_pwr regulator driver for stm32mp157 Pascal Paillet
  2019-10-24 15:41 ` [PATCH 1/1] regulator: stm32_pwr: Enable " Pascal Paillet
@ 2019-10-24 19:31 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-10-24 19:31 UTC (permalink / raw)
  To: Pascal Paillet; +Cc: lgirdwood, linux-kernel, linux-stm32

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

On Thu, Oct 24, 2019 at 05:41:20PM +0200, Pascal Paillet wrote:

> Enable the STM32 PWR regulator driver for stm32mp157 machine.

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff.  This reduces mail volume and ensures that 
any important information is recorded in the changelog rather than being
lost. 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-24 19:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 15:41 [PATCH 0/1] Enable stm32_pwr regulator driver for stm32mp157 Pascal Paillet
2019-10-24 15:41 ` [PATCH 1/1] regulator: stm32_pwr: Enable " Pascal Paillet
2019-10-24 19:31   ` Mark Brown
2019-10-24 19:31 ` [PATCH 0/1] Enable stm32_pwr regulator " Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).