* [PATCH v2] i2c: muxes: pca9541: use BIT() macro
@ 2019-09-05 18:04 Saiyam Doshi
2019-10-24 18:14 ` Saiyam Doshi
0 siblings, 1 reply; 3+ messages in thread
From: Saiyam Doshi @ 2019-09-05 18:04 UTC (permalink / raw)
To: linux, peda; +Cc: linux-i2c, linux-kernel
Use bit mask macro BIT() for definition where appropriate.
Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
---
Changes in v2:
* Include linux/bits.h which defines BIT()
drivers/i2c/muxes/i2c-mux-pca9541.c | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
index 50e1fb4aedf5..c9b17a305bb5 100644
--- a/drivers/i2c/muxes/i2c-mux-pca9541.c
+++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
@@ -16,6 +16,7 @@
* warranty of any kind, whether express or implied.
*/
+#include <linux/bits.h>
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/i2c.h>
@@ -42,20 +43,20 @@
#define PCA9541_CONTROL 0x01
#define PCA9541_ISTAT 0x02
-#define PCA9541_CTL_MYBUS (1 << 0)
-#define PCA9541_CTL_NMYBUS (1 << 1)
-#define PCA9541_CTL_BUSON (1 << 2)
-#define PCA9541_CTL_NBUSON (1 << 3)
-#define PCA9541_CTL_BUSINIT (1 << 4)
-#define PCA9541_CTL_TESTON (1 << 6)
-#define PCA9541_CTL_NTESTON (1 << 7)
-
-#define PCA9541_ISTAT_INTIN (1 << 0)
-#define PCA9541_ISTAT_BUSINIT (1 << 1)
-#define PCA9541_ISTAT_BUSOK (1 << 2)
-#define PCA9541_ISTAT_BUSLOST (1 << 3)
-#define PCA9541_ISTAT_MYTEST (1 << 6)
-#define PCA9541_ISTAT_NMYTEST (1 << 7)
+#define PCA9541_CTL_MYBUS BIT(0)
+#define PCA9541_CTL_NMYBUS BIT(1)
+#define PCA9541_CTL_BUSON BIT(2)
+#define PCA9541_CTL_NBUSON BIT(3)
+#define PCA9541_CTL_BUSINIT BIT(4)
+#define PCA9541_CTL_TESTON BIT(6)
+#define PCA9541_CTL_NTESTON BIT(7)
+
+#define PCA9541_ISTAT_INTIN BIT(0)
+#define PCA9541_ISTAT_BUSINIT BIT(1)
+#define PCA9541_ISTAT_BUSOK BIT(2)
+#define PCA9541_ISTAT_BUSLOST BIT(3)
+#define PCA9541_ISTAT_MYTEST BIT(6)
+#define PCA9541_ISTAT_NMYTEST BIT(7)
#define BUSON (PCA9541_CTL_BUSON | PCA9541_CTL_NBUSON)
#define MYBUS (PCA9541_CTL_MYBUS | PCA9541_CTL_NMYBUS)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] i2c: muxes: pca9541: use BIT() macro
2019-09-05 18:04 [PATCH v2] i2c: muxes: pca9541: use BIT() macro Saiyam Doshi
@ 2019-10-24 18:14 ` Saiyam Doshi
2019-11-19 21:15 ` Peter Rosin
0 siblings, 1 reply; 3+ messages in thread
From: Saiyam Doshi @ 2019-10-24 18:14 UTC (permalink / raw)
To: linux, peda; +Cc: linux-i2c, linux-kernel
Any update / review comment on this?
-Saiyam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] i2c: muxes: pca9541: use BIT() macro
2019-10-24 18:14 ` Saiyam Doshi
@ 2019-11-19 21:15 ` Peter Rosin
0 siblings, 0 replies; 3+ messages in thread
From: Peter Rosin @ 2019-11-19 21:15 UTC (permalink / raw)
To: Saiyam Doshi, linux; +Cc: linux-i2c, linux-kernel
On 2019-10-24 20:14, Saiyam Doshi wrote:
> Any update / review comment on this?
Hi!
Sorry for being unresponsive. It's duplicate effort. There's a
virtually identical previous patch pending
https://patchwork.ozlabs.org/patch/1052566/
That patch has some reviewed-by etc, so I'm going with that.
Cheers,
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-19 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 18:04 [PATCH v2] i2c: muxes: pca9541: use BIT() macro Saiyam Doshi
2019-10-24 18:14 ` Saiyam Doshi
2019-11-19 21:15 ` Peter Rosin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).