Hi Rajat, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc4 next-20191024] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Rajat-Jain/drm-Add-support-for-integrated-privacy-screens/20191025-020550 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f116b96685a046a89c25d4a6ba2da489145c8888 config: i386-defconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:15, from include/linux/list.h:9, from include/linux/kobject.h:19, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from drivers/gpu//drm/drm_privacy_screen.c:8: drivers/gpu//drm/drm_privacy_screen.c: In function 'drm_privacy_screen_present': >> include/linux/kern_levels.h:5:18: warning: format '%s' expects argument of type 'char *', but argument 2 has type 'struct device *' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:12:22: note: in expansion of macro 'KERN_SOH' #define KERN_WARNING KERN_SOH "4" /* warning conditions */ ^~~~~~~~ >> include/drm/drm_print.h:290:15: note: in expansion of macro 'KERN_WARNING' printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) ^~~~~ include/drm/drm_print.h:297:2: note: in expansion of macro '_DRM_PRINTK' _DRM_PRINTK(, WARNING, fmt, ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/gpu//drm/drm_privacy_screen.c:170:3: note: in expansion of macro 'DRM_WARN' DRM_WARN("%s: Odd, connector ACPI node but no privacy scrn?\n", ^~~~~~~~ drivers/gpu//drm/drm_privacy_screen.c:170:14: note: format string is defined here DRM_WARN("%s: Odd, connector ACPI node but no privacy scrn?\n", ~^ -- In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:15, from include/linux/list.h:9, from include/linux/kobject.h:19, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from drivers/gpu/drm/drm_privacy_screen.c:8: drivers/gpu/drm/drm_privacy_screen.c: In function 'drm_privacy_screen_present': >> include/linux/kern_levels.h:5:18: warning: format '%s' expects argument of type 'char *', but argument 2 has type 'struct device *' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:12:22: note: in expansion of macro 'KERN_SOH' #define KERN_WARNING KERN_SOH "4" /* warning conditions */ ^~~~~~~~ >> include/drm/drm_print.h:290:15: note: in expansion of macro 'KERN_WARNING' printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) ^~~~~ include/drm/drm_print.h:297:2: note: in expansion of macro '_DRM_PRINTK' _DRM_PRINTK(, WARNING, fmt, ##__VA_ARGS__) ^~~~~~~~~~~ drivers/gpu/drm/drm_privacy_screen.c:170:3: note: in expansion of macro 'DRM_WARN' DRM_WARN("%s: Odd, connector ACPI node but no privacy scrn?\n", ^~~~~~~~ drivers/gpu/drm/drm_privacy_screen.c:170:14: note: format string is defined here DRM_WARN("%s: Odd, connector ACPI node but no privacy scrn?\n", ~^ vim +/KERN_WARNING +290 include/drm/drm_print.h 02c9656b2f0d69 Haneen Mohammed 2017-10-17 288 02c9656b2f0d69 Haneen Mohammed 2017-10-17 289 #define _DRM_PRINTK(once, level, fmt, ...) \ db87086492581c Joe Perches 2018-03-16 @290 printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) 02c9656b2f0d69 Haneen Mohammed 2017-10-17 291 :::::: The code at line 290 was first introduced by commit :::::: db87086492581c87f768b7d17d01308153ecffc1 drm: Reduce object size of DRM_DEV_ uses :::::: TO: Joe Perches :::::: CC: Daniel Vetter --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation