From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712ECCA9EAF for ; Fri, 25 Oct 2019 02:38:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 404E52166E for ; Fri, 25 Oct 2019 02:38:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hGKpSTAf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390293AbfJYCic (ORCPT ); Thu, 24 Oct 2019 22:38:32 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41386 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728416AbfJYCib (ORCPT ); Thu, 24 Oct 2019 22:38:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=og4UwUe+IdpNdozHFTSH6d+IuI1h2CCsMk4c1RoYWD0=; b=hGKpSTAfckdqYjvK9u9zIy2nf 6fFP+pD1oOAcPxZOa5hynTKk8ls+wO6dg/j82Xfi1hWoX69w/lNvfidaF0u5V/t7DLRO7pclcUkSb yBn1VwK/BWfRVmaQxEJxqYBu2jUWYnUc1izydmJZy0/VGUWeMRt/Qo/S5gcARgDqmNCXNrh7npuKm +/lkQkVZe3hUrg/cACPHYD3QAGoSEbiTz/cJ8ZGmJPYnVxqkr9T1uWkgJq32yFtvhCDdyUgU6DtTO h0zzfoN5mY2AUBxa+JcVsZlNwAuatQlhFiKXJ0Kniflwr0ZqTkV8yRrm6D8ZJtT8cc2/Qzi6JRy2E 6U24WjTog==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNpUk-0003mZ-Kj; Fri, 25 Oct 2019 02:38:30 +0000 Date: Thu, 24 Oct 2019 19:38:30 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Michal Suchanek , linux-scsi@vger.kernel.org, Jonathan Corbet , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , Alexander Viro , Mauro Carvalho Chehab , Eric Biggers , "J. Bruce Fields" , Benjamin Coddington , Hannes Reinecke , Omar Sandoval , Ming Lei , Damien Le Moal , Bart Van Assche , Tejun Heo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code Message-ID: <20191025023830.GA14108@infradead.org> References: <20191024021958.GA11485@infradead.org> <20191024132314.GG2963@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024132314.GG2963@bombadil.infradead.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 24, 2019 at 06:23:14AM -0700, Matthew Wilcox wrote: > On Wed, Oct 23, 2019 at 07:19:58PM -0700, Christoph Hellwig wrote: > > > static > > > -int open_for_data(struct cdrom_device_info *cdi) > > > +int open_for_common(struct cdrom_device_info *cdi, tracktype *tracks) > > > > Please fix the coding style. static never should be on a line of its > > own.. > > It's OK to have the static on a line by itself; it's having 'static int' > on a line by itself that Linus gets unhappy about because he can't use > grep to see the return type. Sorry, but independent of any preference just looking at the codebases proves you wrong. All on one line is the most common style, but not by much, followed by static + type. Just static is just in a few crazy