From: Peter Chen <peter.chen@nxp.com>
To: Pawel Laszczak <pawell@cadence.com>
Cc: Roger Quadros <rogerq@ti.com>,
"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"nsekhar@ti.com" <nsekhar@ti.com>,
Rahul Kumar <kurahul@cadence.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: cdns3: gadget: Don't manage pullups
Date: Fri, 25 Oct 2019 03:13:54 +0000 [thread overview]
Message-ID: <20191025031343.GA13392@b29397-desktop> (raw)
In-Reply-To: <BYAPR07MB4709A6212601A75DCB1A25ACDD6B0@BYAPR07MB4709.namprd07.prod.outlook.com>
On 19-10-23 09:17:45, Pawel Laszczak wrote:
> Hi,
>
> Reviewed-by: Pawel Laszczak <pawell@cadence.com>
Hi Roger & Pawel,
Assume gadget function has already enabled, if you switch host mode
to device mode, with your changes, where the device mode will be enabled
again?
Peter
>
> Regards,
> Pawel,
>
> >The USB gadget core is supposed to manage pullups
> >of the controller. Don't manage pullups from within
> >the controller driver. Otherwise, function drivers
> >are not able to keep the controller disconnected from
> >the bus till they are ready. (e.g. g_webcam)
> >
> >Signed-off-by: Roger Quadros <rogerq@ti.com>
> >---
> >Hi Greg/Felipe,
> >
> >This can be used for -rc as it is a bug fix.
> >
> >cheers,
> >-roger
> >
> > drivers/usb/cdns3/gadget.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> >diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> >index 2ca280f4c054..714382d96055 100644
> >--- a/drivers/usb/cdns3/gadget.c
> >+++ b/drivers/usb/cdns3/gadget.c
> >@@ -2324,8 +2324,6 @@ static void cdns3_gadget_config(struct cdns3_device *priv_dev)
> > writel(USB_CONF_CLK2OFFDS | USB_CONF_L1DS, ®s->usb_conf);
> >
> > cdns3_configure_dmult(priv_dev, NULL);
> >-
> >- cdns3_gadget_pullup(&priv_dev->gadget, 1);
> > }
> >
> > /**
> >@@ -2708,8 +2706,6 @@ static int cdns3_gadget_suspend(struct cdns3 *cdns, bool do_wakeup)
> > /* disable interrupt for device */
> > writel(0, &priv_dev->regs->usb_ien);
> >
> >- cdns3_gadget_pullup(&priv_dev->gadget, 0);
> >-
> > return 0;
> > }
> >
> >--
> >Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> >Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2019-10-25 3:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:02 [PATCH] usb: cdns3: gadget: Don't manage pullups Roger Quadros
2019-10-23 9:17 ` Pawel Laszczak
2019-10-25 3:13 ` Peter Chen [this message]
2019-10-25 9:59 ` Roger Quadros
2019-10-25 10:14 ` Felipe Balbi
2019-10-29 3:12 ` Peter Chen
2019-10-29 9:37 ` Roger Quadros
2019-10-29 10:33 ` Felipe Balbi
2019-10-30 1:15 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025031343.GA13392@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).