From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 899C1CA9EAF for ; Sun, 27 Oct 2019 21:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51BDC21726 for ; Sun, 27 Oct 2019 21:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210864; bh=DioYuE2Fc1xH/kz026vrOKLVWTO8UGykrlspo4l5FX8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eIVHvBm2RSY/Lfhab/ljNzTntnnSUzATGgnGTouldA+jbHeileaRqTpFyrZ3ICDx+ ziqRTGIVoVZnRAxBVr+w9I1miVtT5Ldhd7fXQF+bdsMu+E7VWLD0k9HrSteHsXfmgM A7fvKVLqU6EesAF6cexmviZn1sri3P5slNQnGX2Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730451AbfJ0VOX (ORCPT ); Sun, 27 Oct 2019 17:14:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:33296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728939AbfJ0VOV (ORCPT ); Sun, 27 Oct 2019 17:14:21 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2C7F21726; Sun, 27 Oct 2019 21:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210860; bh=DioYuE2Fc1xH/kz026vrOKLVWTO8UGykrlspo4l5FX8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iFan+Szu/jZnVvcDxHDnr7+gCpqwWri0cmCnecySvTNuIBPAeoyqXatx8SbEed1IU vwuTmHcnMkz30shsUFMjyMVGERMX1yZf9VNh9s46/MzXTHWttC7rT/dDP7068L9Ose QNE7yHq8o/dCWUgf6MZbZpzWd1kXR8IHnJ/2EO0g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.19 43/93] USB: ldusb: fix memleak on disconnect Date: Sun, 27 Oct 2019 22:00:55 +0100 Message-Id: <20191027203258.718959826@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203251.029297948@linuxfoundation.org> References: <20191027203251.029297948@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit b14a39048c1156cfee76228bf449852da2f14df8 upstream. If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data. Fixes: 2824bd250f0b ("[PATCH] USB: add ldusb driver") Cc: stable # 2.6.13 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191010125835.27031-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/ldusb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/misc/ldusb.c +++ b/drivers/usb/misc/ldusb.c @@ -380,10 +380,7 @@ static int ld_usb_release(struct inode * goto exit; } - if (mutex_lock_interruptible(&dev->mutex)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->mutex); if (dev->open_count != 1) { retval = -ENODEV;