From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B0DCA9EAF for ; Sun, 27 Oct 2019 21:09:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8893A208C0 for ; Sun, 27 Oct 2019 21:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210561; bh=ItEhc048PXZwT136OTNM/zwLx86InmHB7Ps6M9y1Pi8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TKPrUuAg9TxlZUs6SlB27oYnj7tYjxgWVq4bhxgGEB5S+SP4RBCCNdAIAqfNcRkhx ynIui0EC7ZajhW/LKh0IH00nyZZ1eqQOxU3pDWbUzha/JG3iy535Mw4ER7ASzY9koY EdYF69Gz/Pg3IrWEo990JETv6Cc3otLQiPEulVzQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729491AbfJ0VJU (ORCPT ); Sun, 27 Oct 2019 17:09:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:55656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727718AbfJ0VJR (ORCPT ); Sun, 27 Oct 2019 17:09:17 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFBB720873; Sun, 27 Oct 2019 21:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210556; bh=ItEhc048PXZwT136OTNM/zwLx86InmHB7Ps6M9y1Pi8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KEZX7esmTP49YrH/EP/v5ENndDebDQalq2bdbzD1nYjLXBf61ggQ2F+fg1woS5lnU G7/ZpjkfiKyVDG3UatkSG31noJ8Hinwk4tb69SzZFlxTwhq4N51aFTSZskHB1MLJ6m ZgDXUQZzKB88GZ5fIcfj4DTcYPkPXlXAAQAV5yP4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Himanshu Madhani , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 003/119] scsi: qla2xxx: Fix unbound sleep in fcport delete path. Date: Sun, 27 Oct 2019 21:59:40 +0100 Message-Id: <20191027203300.527997539@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203259.948006506@linuxfoundation.org> References: <20191027203259.948006506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Quinn Tran [ Upstream commit c3b6a1d397420a0fdd97af2f06abfb78adc370df ] There are instances, though rare, where a LOGO request cannot be sent out and the thread in free session done can wait indefinitely. Fix this by putting an upper bound to sleep. Link: https://lore.kernel.org/r/20190912180918.6436-3-hmadhani@marvell.com Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_target.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 87e04c4a49821..11753ed3433ca 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -996,6 +996,7 @@ static void qlt_free_session_done(struct work_struct *work) if (logout_started) { bool traced = false; + u16 cnt = 0; while (!ACCESS_ONCE(sess->logout_completed)) { if (!traced) { @@ -1005,6 +1006,9 @@ static void qlt_free_session_done(struct work_struct *work) traced = true; } msleep(100); + cnt++; + if (cnt > 200) + break; } ql_dbg(ql_dbg_disc, vha, 0xf087, -- 2.20.1