From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ABACA9EAF for ; Sun, 27 Oct 2019 21:08:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAC3F208C0 for ; Sun, 27 Oct 2019 21:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210503; bh=Fh4dzU4UG4Qrpjq7yDidh3ux/mXdZHZdENBjLFk4hbM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=r5Xl9QTYVy83n4GQ7cyfWWpjjlkiTu/CD8L5UQxT6+aXJBI/bUNUL6fg1eH679bg1 OOWsqrSWRP6IdReoKOfADPzgFKF1rwzx4wnTTOylSPbETRlxmgXekEl7Qr6ihXzRoF u6BCByXLLL/N9Ju7poX853q66hZSlz0A3CuBrX60= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729346AbfJ0VIW (ORCPT ); Sun, 27 Oct 2019 17:08:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:54510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728484AbfJ0VIR (ORCPT ); Sun, 27 Oct 2019 17:08:17 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95133208C0; Sun, 27 Oct 2019 21:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210497; bh=Fh4dzU4UG4Qrpjq7yDidh3ux/mXdZHZdENBjLFk4hbM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qNc744yI/H4Eb49TqfPvmHQNtWWKV0JKaEvYSDoNAk8Sot2+s0gCPcZAH/FmMYbgQ ijGExKpOrt/c4LUUvpQWtDPWob0nHJjhrsxLydHx2mczakDmsGkXWJ2aquz2FdiD+H OppCdxAS7+QMaKyrrRSfxh/zxbj1LGYolezQUBbw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.14 034/119] USB: ldusb: fix memleak on disconnect Date: Sun, 27 Oct 2019 22:00:11 +0100 Message-Id: <20191027203310.819119455@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203259.948006506@linuxfoundation.org> References: <20191027203259.948006506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit b14a39048c1156cfee76228bf449852da2f14df8 upstream. If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data. Fixes: 2824bd250f0b ("[PATCH] USB: add ldusb driver") Cc: stable # 2.6.13 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191010125835.27031-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/ldusb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/misc/ldusb.c +++ b/drivers/usb/misc/ldusb.c @@ -383,10 +383,7 @@ static int ld_usb_release(struct inode * goto exit; } - if (mutex_lock_interruptible(&dev->mutex)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->mutex); if (dev->open_count != 1) { retval = -ENODEV;