linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sheetal.tigadoli@broadcom.com
Cc: zajec5@gmail.com, gregkh@linuxfoundation.org,
	michal.simek@xilinx.com, rajan.vaja@xilinx.com,
	scott.branden@broadcom.com, ray.jui@broadcom.com,
	vikram.prakash@broadcom.com, jens.wiklander@linaro.org,
	michael.chan@broadcom.com, vikas.gupta@broadcom.com,
	vasundhara-v.volam@broadcom.com, linux-kernel@vger.kernel.org,
	tee-dev@lists.linaro.org, bcm-kernel-feedback-list@broadcom.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager
Date: Mon, 28 Oct 2019 12:01:13 -0700 (PDT)	[thread overview]
Message-ID: <20191028.120113.302853319604481823.davem@davemloft.net> (raw)
In-Reply-To: <20191028.114915.4026077453899574.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Mon, 28 Oct 2019 11:49:15 -0700 (PDT)

> From: Sheetal Tigadoli <sheetal.tigadoli@broadcom.com>
> Date: Thu, 24 Oct 2019 11:02:38 +0530
> 
>> This patch series adds support for TEE based BNXT firmware
>> management module and the driver changes to invoke OP-TEE
>> APIs to fastboot firmware and to collect crash dump.
>> 
>> changes from v2:
>>  - address review comments from Jakub
> 
> Series applied to net-next.
> 
> Please properly annotate your Subject lines in the future to indicate
> the exact GIT tree your patches are targetting, ala "[PATCH net-next ...]"

Actually, reverted, this doesn't even compile:

drivers/firmware/broadcom/tee_bnxt_fw.c: In function ‘prepare_args’:
drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: error: ‘SZ_4M’ undeclared (first use in this function)
 #define MAX_SHM_MEM_SZ SZ_4M
                        ^~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:81:28: note: in expansion of macro ‘MAX_SHM_MEM_SZ’
   param[0].u.memref.size = MAX_SHM_MEM_SZ;
                            ^~~~~~~~~~~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: note: each undeclared identifier is reported only once for each function it appears in
 #define MAX_SHM_MEM_SZ SZ_4M
                        ^~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:81:28: note: in expansion of macro ‘MAX_SHM_MEM_SZ’
   param[0].u.memref.size = MAX_SHM_MEM_SZ;
                            ^~~~~~~~~~~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c: In function ‘tee_bnxt_fw_probe’:
drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: error: ‘SZ_4M’ undeclared (first use in this function)
 #define MAX_SHM_MEM_SZ SZ_4M
                        ^~~~~
drivers/firmware/broadcom/tee_bnxt_fw.c:214:44: note: in expansion of macro ‘MAX_SHM_MEM_SZ’
  fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
                                            ^~~~~~~~~~~~~~

      reply	other threads:[~2019-10-28 19:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  5:32 [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager Sheetal Tigadoli
2019-10-24  5:32 ` [PATCH V3 1/3] firmware: broadcom: add OP-TEE based BNXT " Sheetal Tigadoli
2019-10-24 18:54   ` Jakub Kicinski
2019-10-27  5:12   ` kbuild test robot
2019-10-30 10:44   ` [Tee-dev] " Sumit Garg
2019-10-24  5:32 ` [PATCH V3 2/3] bnxt_en: Add support to invoke OP-TEE API to reset firmware Sheetal Tigadoli
2019-10-24  5:32 ` [PATCH V3 3/3] bnxt_en: Add support to collect crash dump via ethtool Sheetal Tigadoli
2019-10-24 18:55   ` Jakub Kicinski
2019-10-24 18:39 ` [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager Florian Fainelli
2019-10-25  0:06   ` Florian Fainelli
2019-10-28 18:49 ` David Miller
2019-10-28 19:01   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028.120113.302853319604481823.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=rajan.vaja@xilinx.com \
    --cc=ray.jui@broadcom.com \
    --cc=scott.branden@broadcom.com \
    --cc=sheetal.tigadoli@broadcom.com \
    --cc=tee-dev@lists.linaro.org \
    --cc=vasundhara-v.volam@broadcom.com \
    --cc=vikas.gupta@broadcom.com \
    --cc=vikram.prakash@broadcom.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).