From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7248CA9EBC for ; Mon, 28 Oct 2019 07:39:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C64F7214E0 for ; Mon, 28 Oct 2019 07:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733015AbfJ1Hj5 (ORCPT ); Mon, 28 Oct 2019 03:39:57 -0400 Received: from verein.lst.de ([213.95.11.211]:33113 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730952AbfJ1Hj4 (ORCPT ); Mon, 28 Oct 2019 03:39:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 480AA68C65; Mon, 28 Oct 2019 08:39:53 +0100 (CET) Date: Mon, 28 Oct 2019 08:39:53 +0100 From: Christoph Hellwig To: Guenter Roeck Cc: Keith Busch , Chris Healy , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Akinobu Mita , linux-pm@vger.kernel.org Subject: Re: [PATCH] nvme: Add hardware monitoring support Message-ID: <20191028073953.GA20443@lst.de> References: <20191028024156.23964-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028024156.23964-1-linux@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 27, 2019 at 07:41:56PM -0700, Guenter Roeck wrote: > nvme devices report temperature information in the controller information > (for limits) and in the smart log. Currently, the only means to retrieve > this information is the nvme command line interface, which requires > super-user privileges. > > At the same time, it would be desirable to use NVME temperature information > for thermal control. > > This patch adds support to read NVME temperatures from the kernel using the > hwmon API and adds temperature zones for NVME drives. The thermal subsystem > can use this information to set thermal policies, and userspace can access > it using libsensors and/or the "sensors" command. So these reported values seem to generate some interest. Adding Akinobu Mita who also planned to wire them up to the thermal framework. I don't really know either upper layer so I'm not sure which is the right one, but with this just like with the previous series I am quite worried that we add a lot of kernel boilerplate code for information people can trivially get using nvme-cli.