From: James Clark <James.Clark@arm.com>
To: "linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: nd <nd@arm.com>, "acme@redhat.com" <acme@redhat.com>,
"irogers@google.com" <irogers@google.com>,
James Clark <James.Clark@arm.com>
Subject: [PATCH] Fixes issue when debugging debug builds of Perf.
Date: Mon, 28 Oct 2019 11:34:01 +0000 [thread overview]
Message-ID: <20191028113340.4282-1-james.clark@arm.com> (raw)
When a 'make DEBUG=1' build is done, the command parser
is still built with -O6 and is hard to step through.
This change also moves EXTRA_WARNINGS and EXTRA_FLAGS to
the end of the compilation line, otherwise they cannot be
used to override the default values.
Signed-off-by: James Clark <james.clark@arm.com>
---
tools/lib/subcmd/Makefile | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile
index 5b2cd5e58df0..1c777a72bb39 100644
--- a/tools/lib/subcmd/Makefile
+++ b/tools/lib/subcmd/Makefile
@@ -19,8 +19,7 @@ MAKEFLAGS += --no-print-directory
LIBFILE = $(OUTPUT)libsubcmd.a
-CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
-CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -fPIC
+CFLAGS := -ggdb3 -Wall -Wextra -std=gnu99 -fPIC
ifeq ($(DEBUG),0)
ifeq ($(feature-fortify-source), 1)
@@ -28,7 +27,9 @@ ifeq ($(DEBUG),0)
endif
endif
-ifeq ($(CC_NO_CLANG), 0)
+ifeq ($(DEBUG),1)
+ CFLAGS += -O0
+else ifeq ($(CC_NO_CLANG), 0)
CFLAGS += -O3
else
CFLAGS += -O6
@@ -43,6 +44,8 @@ CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
CFLAGS += -I$(srctree)/tools/include/
+CFLAGS += $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
+
SUBCMD_IN := $(OUTPUT)libsubcmd-in.o
all:
--
2.23.0
next reply other threads:[~2019-10-28 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 11:34 James Clark [this message]
2019-10-29 14:00 ` [PATCH] Fixes issue when debugging debug builds of Perf Arnaldo Carvalho de Melo
2019-10-29 14:18 ` Arnaldo Carvalho de Melo
2019-10-29 14:26 ` Arnaldo Carvalho de Melo
2019-10-30 11:03 ` James Clark
2019-10-30 15:13 ` Arnaldo Carvalho de Melo
2019-11-12 11:18 ` [tip: perf/core] libsubcmd: Move EXTRA_FLAGS to the end to allow overriding existing flags tip-bot2 for James Clark
2019-11-12 11:18 ` [tip: perf/core] libsubcmd: Use -O0 with DEBUG=1 tip-bot2 for James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028113340.4282-1-james.clark@arm.com \
--to=james.clark@arm.com \
--cc=acme@redhat.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).