From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, eranian@google.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v3 1/7] perf pmu: Use file system cache to optimize sysfs access
Date: Mon, 28 Oct 2019 23:01:37 +0100 [thread overview]
Message-ID: <20191028220137.GF28772@krava> (raw)
In-Reply-To: <20191025181417.10670-2-andi@firstfloor.org>
On Fri, Oct 25, 2019 at 11:14:11AM -0700, Andi Kleen wrote:
SNIP
> if (pmu_aliases_parse(path, head))
> return -1;
> @@ -525,7 +524,6 @@ static int pmu_alias_terms(struct perf_pmu_alias *alias,
> */
> static int pmu_type(const char *name, __u32 *type)
> {
> - struct stat st;
> char path[PATH_MAX];
> FILE *file;
> int ret = 0;
> @@ -537,7 +535,7 @@ static int pmu_type(const char *name, __u32 *type)
> snprintf(path, PATH_MAX,
> "%s" EVENT_SOURCE_DEVICE_PATH "%s/type", sysfs, name);
>
> - if (stat(path, &st) < 0)
> + if (access(path, R_OK) < 0)
why not file_available call in here?
jirka
> return -1;
>
> file = fopen(path, "r");
> @@ -628,14 +626,11 @@ static struct perf_cpu_map *pmu_cpumask(const char *name)
> static bool pmu_is_uncore(const char *name)
> {
> char path[PATH_MAX];
> - struct perf_cpu_map *cpus;
> - const char *sysfs = sysfs__mountpoint();
> + const char *sysfs;
>
> + sysfs = sysfs__mountpoint();
> snprintf(path, PATH_MAX, CPUS_TEMPLATE_UNCORE, sysfs, name);
SNIP
next prev parent reply other threads:[~2019-10-28 22:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 18:14 Optimize perf stat for large number of events/cpus v3 Andi Kleen
2019-10-25 18:14 ` [PATCH v3 1/7] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-10-28 22:01 ` Jiri Olsa [this message]
2019-10-29 2:14 ` Andi Kleen
2019-10-25 18:14 ` [PATCH v3 2/7] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-10-25 18:14 ` [PATCH v3 3/7] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-10-30 10:05 ` Jiri Olsa
2019-10-30 10:06 ` Jiri Olsa
2019-10-30 15:51 ` Andi Kleen
2019-10-30 18:15 ` Jiri Olsa
2019-10-30 19:03 ` Andi Kleen
2019-11-01 8:38 ` Jiri Olsa
2019-10-25 18:14 ` [PATCH v3 4/7] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-10-30 10:05 ` Jiri Olsa
2019-11-04 23:35 ` Andi Kleen
2019-10-25 18:14 ` [PATCH v3 5/7] perf stat: Use affinity for opening events Andi Kleen
2019-10-30 10:06 ` Jiri Olsa
2019-10-25 18:14 ` [PATCH v3 6/7] perf stat: Use affinity for reading Andi Kleen
2019-10-25 18:14 ` [PATCH v3 7/7] perf stat: Use affinity for enabling/disabling events Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028220137.GF28772@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).