From: Samuil Ivanov <samuil.ivanovbg@gmail.com>
To: rspringer@google.com, toddpoynor@google.com,
benchan@chromium.org, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Samuil Ivanov <samuil.ivanovbg@gmail.com>
Subject: [PATCH 2/2] Staging: gasket: Clean apex_get_status function of comment
Date: Tue, 29 Oct 2019 00:59:26 +0200 [thread overview]
Message-ID: <20191028225926.8951-3-samuil.ivanovbg@gmail.com> (raw)
In-Reply-To: <20191028225926.8951-1-samuil.ivanovbg@gmail.com>
After implementing the function to check the status of the driver,
there is no longer need for this comment.
Signed-off-by: Samuil Ivanov <samuil.ivanovbg@gmail.com>
---
drivers/staging/gasket/apex_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
index a5dd6f3c367d..67cdb4f5da8e 100644
--- a/drivers/staging/gasket/apex_driver.c
+++ b/drivers/staging/gasket/apex_driver.c
@@ -246,7 +246,6 @@ module_param(bypass_top_level, int, 0644);
/* Check the device status registers and return device status ALIVE or DEAD. */
static int apex_get_status(struct gasket_dev *gasket_dev)
{
- /* TODO: Check device status. */
if (gasket_dev->status == GASKET_STATUS_DEAD)
return GASKET_STATUS_DEAD;
--
2.17.1
prev parent reply other threads:[~2019-10-28 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 22:59 [PATCH 0/2] Staging: gasket: Implement apex_get_status() to check driver status Samuil Ivanov
2019-10-28 22:59 ` [PATCH 1/2] Staging: gasket: implement " Samuil Ivanov
2019-10-29 8:10 ` Greg KH
2019-10-29 15:22 ` Samuil Ivanov
2019-10-28 22:59 ` Samuil Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028225926.8951-3-samuil.ivanovbg@gmail.com \
--to=samuil.ivanovbg@gmail.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).