From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 404B4CA9EC0 for ; Tue, 29 Oct 2019 01:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A0CC217D6 for ; Tue, 29 Oct 2019 01:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="A9YyLgNh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728778AbfJ2BZU (ORCPT ); Mon, 28 Oct 2019 21:25:20 -0400 Received: from vps.xff.cz ([195.181.215.36]:51970 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728275AbfJ2BZT (ORCPT ); Mon, 28 Oct 2019 21:25:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1572312318; bh=yZJ2tr1txca9SLDOy4OtsLu+iAa2f0cZDLnWQ7+OML8=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=A9YyLgNhvrxlUztIuCRhuPElEulYpYKTMOb3Hdyf6b5wAYii97AeXsS/rGMCkEskW C0mY/yPIhHdiJKF25+6vtI21q6NsMXjfK/3/CxdTMg40ZTSycRT5LkucjHFQUkMiKD jKO8p4ACl0Huenevm29Hl1sHst+Z8pOKmICnXozU= Date: Tue, 29 Oct 2019 02:25:17 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Chen-Yu Tsai Cc: linux-sunxi , stable , Maxime Ripard , Russell King , "moderated list:ARM/Allwinner sunXi SoC support" , open list Subject: Re: [linux-sunxi] [PATCH] ARM: sunxi: Fix CPU powerdown on A83T Message-ID: <20191029012517.eddekmphtxyslevx@core.my.home> Mail-Followup-To: Chen-Yu Tsai , linux-sunxi , stable , Maxime Ripard , Russell King , "moderated list:ARM/Allwinner sunXi SoC support" , open list References: <20191028214914.3465156-1-megous@megous.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 09:09:40AM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 29, 2019 at 5:49 AM Ondrej Jirman wrote: > > > > PRCM_PWROFF_GATING_REG has CPU0 at bit 4 on A83T. So without this > > patch, instead of gating the CPU0, the whole cluster was power gated, > > when shutting down first CPU in the cluster. > > > > Fixes: 6961275e72a8c1 ("ARM: sun8i: smp: Add support for A83T") > > Signed-off-by: Ondrej Jirman > > Cc: stable@vger.kernel.org > > Acked-by: Chen-Yu Tsai > > Though I distinctly remember the BSP had some code dealing with chip > revisions in which the two bits were reversed. :( Actually, it's a bit more complicated. There's a special check in BSP code (grep for SUN8IW6P1_REV_A) that instead of power gating, just holds the core in reset for that revision. regards, o.