From: Simon Horman <simon.horman@netronome.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: kvalo@codeaurora.org, davem@davemloft.net, swinslow@gmail.com,
will@kernel.org, opensource@jilayne.com, baijiaju1990@gmail.com,
tglx@linutronix.de, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] b43: Fix use true/false for bool type
Date: Tue, 29 Oct 2019 09:43:21 +0100 [thread overview]
Message-ID: <20191029084320.GC23615@netronome.com> (raw)
In-Reply-To: <20191029082427.GB23615@netronome.com>
On Tue, Oct 29, 2019 at 09:24:27AM +0100, Simon Horman wrote:
> Hi Saurav,
>
> thanks for your patch.
>
> On Tue, Oct 29, 2019 at 12:32:04AM +0530, Saurav Girepunje wrote:
> > use true/false on bool type variable assignment.
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>
> This does not seem to cover the case in dma.c,
> which seems to want fixing for the sake of consistency.
I now see this handled in a separate patch, sorry for the noise.
> Also, I wonder why bools rather than a bitmask was chosen
> for this field, it seems rather space intensive in its current form.
>
> > ---
> > drivers/net/wireless/broadcom/b43/main.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
> > index b85603e91c7a..39da1a4c30ac 100644
> > --- a/drivers/net/wireless/broadcom/b43/main.c
> > +++ b/drivers/net/wireless/broadcom/b43/main.c
> > @@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
> > else
> > err = b43_dma_tx(dev, skb);
> > if (err == -ENOSPC) {
> > - wl->tx_queue_stopped[queue_num] = 1;
> > + wl->tx_queue_stopped[queue_num] = true;
> > ieee80211_stop_queue(wl->hw, queue_num);
> > skb_queue_head(&wl->tx_queue[queue_num], skb);
> > break;
> > @@ -3611,7 +3611,7 @@ static void b43_tx_work(struct work_struct *work)
> > }
> >
> > if (!err)
> > - wl->tx_queue_stopped[queue_num] = 0;
> > + wl->tx_queue_stopped[queue_num] = false;
> > }
> >
> > #if B43_DEBUG
> > @@ -5603,7 +5603,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev)
> > /* Initialize queues and flags. */
> > for (queue_num = 0; queue_num < B43_QOS_QUEUE_NUM; queue_num++) {
> > skb_queue_head_init(&wl->tx_queue[queue_num]);
> > - wl->tx_queue_stopped[queue_num] = 0;
> > + wl->tx_queue_stopped[queue_num] = false;
> > }
> >
> > snprintf(chip_name, ARRAY_SIZE(chip_name),
> > --
> > 2.20.1
> >
>
next prev parent reply other threads:[~2019-10-29 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 19:02 [PATCH] b43: Fix use true/false for bool type Saurav Girepunje
2019-10-29 8:24 ` Simon Horman
2019-10-29 8:30 ` Joe Perches
2019-10-29 8:43 ` Simon Horman
2019-10-29 8:43 ` Simon Horman [this message]
2019-10-31 8:07 ` [PATCH] b43: main: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029084320.GC23615@netronome.com \
--to=simon.horman@netronome.com \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opensource@jilayne.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=swinslow@gmail.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).