From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7742CA9EAE for ; Tue, 29 Oct 2019 09:08:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C777720717 for ; Tue, 29 Oct 2019 09:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730972AbfJ2JIU (ORCPT ); Tue, 29 Oct 2019 05:08:20 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:36453 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730518AbfJ2JIU (ORCPT ); Tue, 29 Oct 2019 05:08:20 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iPNTu-0002XP-O9; Tue, 29 Oct 2019 10:08:02 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iPNTt-0007YZ-T6; Tue, 29 Oct 2019 10:08:01 +0100 Date: Tue, 29 Oct 2019 10:08:01 +0100 From: Marco Felsch To: Ondrej Jirman Cc: linux-sunxi@googlegroups.com, Dmitry Torokhov , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Andy Shevchenko , Greg Kroah-Hartman , =?iso-8859-1?Q?Myl=E8ne?= Josserand , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] arm: dts: sun8i: a83t: a711: Add touchscreen node Message-ID: <20191029090801.zls2qns7rxcvmxor@pengutronix.de> References: <20191029005806.3577376-1-megous@megous.com> <20191029005806.3577376-4-megous@megous.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191029005806.3577376-4-megous@megous.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:04:51 up 164 days, 15:23, 99 users, load average: 0.20, 0.17, 0.08 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19-10-29 01:58, Ondrej Jirman wrote: > From: Mylène Josserand > > Enable a FocalTech EDT-FT5x06 Polytouch touchscreen. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Mylène Josserand > --- > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > index 568b90ece342..19f520252dc5 100644 > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > @@ -164,6 +164,22 @@ > status = "okay"; > }; > > +&i2c0 { > + clock-frequency = <400000>; > + status = "okay"; > + > + touchscreen@38 { > + compatible = "edt,edt-ft5x06"; > + reg = <0x38>; > + interrupt-parent = <&r_pio>; > + interrupts = <0 7 IRQ_TYPE_EDGE_FALLING>; /* PL7 */ > + reset-gpios = <&pio 3 5 GPIO_ACTIVE_LOW>; /* PD5 */ > + vcc-supply = <®_ldo_io0>; > + touchscreen-size-x = <1024>; > + touchscreen-size-y = <600>; Do you want this touchscreen as wakeup-src? If so please add the property here. I've send patches converting the driver from the default behaviour: https://patchwork.kernel.org/cover/11149039/ and all agreed to break backward compatibility. Regards, Marco > + }; > +}; > + > &i2c1 { > clock-frequency = <400000>; > status = "okay"; > -- > 2.23.0 > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |