From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3A5CA9EC4 for ; Tue, 29 Oct 2019 09:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E5B82083E for ; Tue, 29 Oct 2019 09:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731799AbfJ2JZW (ORCPT ); Tue, 29 Oct 2019 05:25:22 -0400 Received: from mga18.intel.com ([134.134.136.126]:18923 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727257AbfJ2JZW (ORCPT ); Tue, 29 Oct 2019 05:25:22 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 02:25:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,243,1569308400"; d="scan'208";a="198871215" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.122]) by fmsmga007.fm.intel.com with ESMTP; 29 Oct 2019 02:25:17 -0700 Date: Tue, 29 Oct 2019 11:25:16 +0200 From: Jarkko Sakkinen To: Mimi Zohar Cc: David Howells , Petr Vorel , shuah , James Bottomley , linux-integrity@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] selftest/trustedkeys: TPM 1.2 trusted keys test Message-ID: <20191029092516.GA13848@linux.intel.com> References: <1571944467-13097-1-git-send-email-zohar@linux.ibm.com> <20191028203014.GA8279@linux.intel.com> <1572295513.4532.270.camel@linux.ibm.com> <20191029091535.GB9896@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191029091535.GB9896@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 11:15:35AM +0200, Jarkko Sakkinen wrote: > On Mon, Oct 28, 2019 at 04:45:13PM -0400, Mimi Zohar wrote: > > On Mon, 2019-10-28 at 22:30 +0200, Jarkko Sakkinen wrote: > > > On Thu, Oct 24, 2019 at 03:14:27PM -0400, Mimi Zohar wrote: > > > > Create, save and load trusted keys test > > > > > > > > Signed-off-by: Mimi Zohar > > > > > > > > Change log v1: > > > > - Replace the directions for using Trousers to take ownership of the TPM > > > > with directions for using the IBM TSS. > > > > - Differentiate between different types of errors. Recent bug is causing > > > > "add_key: Timer expired". > > > > --- > > > > > > Is not really usable as a selftest because of 3rd party dependencies. > > > > As part of diagnosing trusted keys failure, there is some > > hints/directions as to how to take TPM 1.2 ownership, but it does not > > take ownership.  The previous version included directions for using > > Trousers.  This version provides directions for using the IBM TSS. > >  Feel free to include additional hints/directions. > > You must write your own minimal user space that can be included > to the kernel. Otherwise, we cannot take it. I'll anyway try to setup user space with TrouSerS so that I can try it out. BuildRoot has recipe for that but not for IBM TSS 2.0 so I'll skip that and use my own test script for TPM2 trusted keys. /Jarkko