From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94061CA9EC3 for ; Tue, 29 Oct 2019 16:41:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66E9B2087F for ; Tue, 29 Oct 2019 16:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HG4z30Tu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390496AbfJ2QlO (ORCPT ); Tue, 29 Oct 2019 12:41:14 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45802 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390258AbfJ2QlN (ORCPT ); Tue, 29 Oct 2019 12:41:13 -0400 Received: by mail-pg1-f194.google.com with SMTP id r1so9937921pgj.12 for ; Tue, 29 Oct 2019 09:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H/SwnEWBgpO8uhQ3EMFcAeMVwoZ0LhooyFwQgCGtCb8=; b=HG4z30TuA7/IKrzPnmFV4mK1PPn6OLcaWbWuq+hpE8D0XMINay8grcpjCZY3X3zuAe aL/C+yCQ9+WIXOFFMAnfECbV7Uo8CrzEh+LS9YywIXYlojHMILN9HWblYKeki+05uqT3 WtC0Ra+HH+p/eQLxly54DtXtlJ/SNFaAbAbOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H/SwnEWBgpO8uhQ3EMFcAeMVwoZ0LhooyFwQgCGtCb8=; b=m0/8IJSAebtAbHX5L+zyPwuLe5JeE2LrCa8NM90cu9cLW8XZL5dBWuXtJ3jf1invgy O8Jhbcv9Q9WzZMN/bYmnlG373c07hcyyMJSQiprq7rCEWBonLVtlgKN9UM7cPoQYCPTq XF5Dzx7j1YDL30wBo1rwkaGLdk7P/kl6BzvJYAre3OwUlZPCDZTjX+CJQTpbF3+NIrX8 GV2BhqHgHV/j4s+r6BuCNxwmezu4WjUB2GDzT1qI5gCGQz0Gr6CvqvjCGIOdOIM/l0rM HgxU49pLC5C+nNyXIeJadURAh3uI03M/B94HpVV0cCzb0/99MQjcJwK0A5FnWumGfN/F x2dw== X-Gm-Message-State: APjAAAVPi3+W5e//bhUIAcxXO5S8pgqATWJwF2670Z6Z3D0GO3Z8+EA8 C7L6I0zx3YikdyvSNzvt77IlsP2VsTA= X-Google-Smtp-Source: APXvYqxqzxwtzPTcK0jqMUGTNz/tUufSeZeNXEy531rEV50WFFZvzK8YenHaMyj3YlfYhge+82MJuw== X-Received: by 2002:a62:1517:: with SMTP id 23mr28248138pfv.236.1572367273277; Tue, 29 Oct 2019 09:41:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p9sm9355020pfq.40.2019.10.29.09.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 09:41:12 -0700 (PDT) Date: Tue, 29 Oct 2019 09:41:11 -0700 From: Kees Cook To: "Ben Dooks (Codethink)" Cc: linux-kernel@lists.codethink.co.uk, Anton Vorontsov , Colin Cross , Tony Luck , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pstore: make 'pstore_choose_compression' static Message-ID: <201910290940.E90A2D2B1D@keescook> References: <20191016123317.3154-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016123317.3154-1-ben.dooks@codethink.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 16, 2019 at 01:33:17PM +0100, Ben Dooks (Codethink) wrote: > The pstore_choose_compression function is not exported > so make it static to avoid the following sparse warning: > > fs/pstore/platform.c:796:13: warning: symbol 'pstore_choose_compression' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Oops! Yes, thank you. Applied to my for-next/pstore branch. :) -Kees > --- > Cc: Kees Cook > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Tony Luck > Cc: linux-kernel@vger.kernel.org > --- > fs/pstore/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c > index 3d7024662d29..d896457e7c11 100644 > --- a/fs/pstore/platform.c > +++ b/fs/pstore/platform.c > @@ -793,7 +793,7 @@ static void pstore_timefunc(struct timer_list *unused) > jiffies + msecs_to_jiffies(pstore_update_ms)); > } > > -void __init pstore_choose_compression(void) > +static void __init pstore_choose_compression(void) > { > const struct pstore_zbackend *step; > > -- > 2.23.0 > -- Kees Cook