From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D17DCA9EAE for ; Tue, 29 Oct 2019 11:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5660221734 for ; Tue, 29 Oct 2019 11:17:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="oP0ccVAs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387589AbfJ2LR5 (ORCPT ); Tue, 29 Oct 2019 07:17:57 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:36186 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728462AbfJ2LRr (ORCPT ); Tue, 29 Oct 2019 07:17:47 -0400 Received-SPF: Pass (esa5.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa5.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa5.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa5.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa5.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: yC2qnlR7HAhq1ck88Q8HVDAub5WBHiuZhMbAww6Mn2fSBSLPUS6LxvjF2kqUM3n+E99N20QdQq lW7dyHj1SUXCvF/slDP1R3GCqYnchEVSb5BM8WGOfLkDkbkh58xnLQM2Xw7mmkLmCL5IkO5Or2 GUC+LW0qc78AvW6uJ6Q8cwmhsAdRnmK+yPVHUeUnMn0+c5ZM+Q4yCc04dVBRHLjUPiHGPJSX2l 3etWhNno9Wff8Q3KackPMqks9RgQt5CSUPO0TGAEUzr3D7JFT399YroQk52ieVblbfO31Dv99g kSk= X-IronPort-AV: E=Sophos;i="5.68,243,1569308400"; d="scan'208";a="53292162" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 29 Oct 2019 04:17:47 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 29 Oct 2019 04:17:33 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 29 Oct 2019 04:17:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hJoPcEbgtl/1jaoA82MRMA5otSmraL07YKnqgL2DetoNU3ykpiKvWX03KM3KgERw6Fp5uTym2E5qkrcqPxdGWf45rfjFGwKDOVsbijypleeJ9FceBH6VADc76147f5PaoZlkdnQMaszuFpJ4sf5H9NgRv4sIz046+wVOiYSs7SGtZlk3D+n9RlhVm0Wly9goAYkR95PDCU2dua/qHSinbkR3T1B+UBt18/Vx5FU6TthC9gYt5XJmxGTss2vCHW/nGI9LVrhTwR4bfngaMXtom2hV5ep4K1436fSFleYAxbY4dVBplOJnijSg0/0lXGSPbaRtqDi+tewhFzplw66HuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dbkxin11NQr3UDreJPR2nfDV4TXXS9nQ6US790mMMRE=; b=Esn1mD/5dL/r020s1Wm4pmWnbtXB71SG/eDmhdWnk5kpvRYM1owZalBo8Ot1qAVodYl3yiqkQYG9uGlp5ggWdCK789s3T/T1GErfnIodXARLuDhcNkbKv/bbDBUaUd6/Xy6l33KEoo8rKKdoNEKK92hUS+4k2whXniuhge0TdZExdl2ELOK9Mhuvi0ljuSeiRYTD/CewrzyoIuN22xSHa78NIo834BzB+o2vLUtx3YnUjuAOM4yQvRjZMPsTBgckyxlvWs53mDJE4bOsV3Dc7fPPsZkwG7og99IGR40W3C+YFZ1MsG5AvN1yu2HaucuxicKxR+RtKpBDIilVmYx9wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dbkxin11NQr3UDreJPR2nfDV4TXXS9nQ6US790mMMRE=; b=oP0ccVAshEiKGaqYA72jFdTA0z+A4GeUud5UQR+Y67p6Qr1lyVOVltfZVqJRgNAu0U6j6XDGnh0pP4aPtDTg1TcoPQOvF2JF1wj58D/cg4vLmQkH5xjUMl2+1qzSI5qBcarFU+I89fc5q43XXVj+fT1hFcNqQaYccYRFWq4Tcpc= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB3712.namprd11.prod.outlook.com (20.178.253.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20; Tue, 29 Oct 2019 11:17:32 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::c09c:36c8:3301:4457]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::c09c:36c8:3301:4457%5]) with mapi id 15.20.2387.027; Tue, 29 Oct 2019 11:17:32 +0000 From: To: , , , CC: , , Subject: [PATCH v3 27/32] mtd: spi-nor: Extend the QE Read Back test to both SR1 and SR2 Thread-Topic: [PATCH v3 27/32] mtd: spi-nor: Extend the QE Read Back test to both SR1 and SR2 Thread-Index: AQHVjkp1Z9fauPXm60Chr6Rr+/URxw== Date: Tue, 29 Oct 2019 11:17:32 +0000 Message-ID: <20191029111615.3706-28-tudor.ambarus@microchip.com> References: <20191029111615.3706-1-tudor.ambarus@microchip.com> In-Reply-To: <20191029111615.3706-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0376.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::28) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.9.5 x-originating-ip: [83.166.207.93] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78264a18-a137-4361-7d12-08d75c619794 x-ms-traffictypediagnostic: MN2PR11MB3712: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-forefront-prvs: 0205EDCD76 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(366004)(396003)(136003)(376002)(39860400002)(189003)(199004)(107886003)(6512007)(316002)(110136005)(4326008)(2201001)(305945005)(6436002)(54906003)(7736002)(2906002)(66946007)(66476007)(66556008)(64756008)(66446008)(6116002)(3846002)(6486002)(5660300002)(36756003)(86362001)(11346002)(446003)(8936002)(81156014)(81166006)(50226002)(2616005)(186003)(476003)(256004)(478600001)(8676002)(25786009)(14454004)(486006)(66066001)(2501003)(26005)(99286004)(386003)(76176011)(52116002)(1076003)(102836004)(14444005)(71200400001)(71190400001)(6506007);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB3712;H:MN2PR11MB4448.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gJ6BwcoRR5Mu21WeSjBVXMkKY+QJYeyrDPEexEUXgFrv8KgPfpxCOqQz0gyVOn65mY53dPSxzUe4rpmp6KraLgLKviT4vehVCcc6SNb4eQQ5b5MmwSmSpzYrRF+846f5TRSOewc0cVPIkZ9TdNl7KqcqVOag4lj0YBLmCP7v3qArRmZ6lI2EWch7t22DbJcr00TqGN7AMerpYCRFPLKJRUHaGh2sm9gWPgCu5RMiVD9NBrHViTO/J9Rhi5ho3tzX1Z276CmyZC+7Efi2ZfrzqmlkO9lve/jC1K0+Onhp/ZUZ9jaQlldaH/HwJFONBUayQxBja2m4yMXkIvuH+Wg2SqoJHLBb8XizszuYMQtnmHaD/IieBq9SuWXIAYO6Epohb8m0BOrJEI9FNa3jGyv/aIYnsqAjQK98yYfv1w64R/i3L22Xt5v01hQyXnMcgBxO Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 78264a18-a137-4361-7d12-08d75c619794 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2019 11:17:32.2537 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: znu8F2Z5lHsMrE4SunH/Tsgk1sXM1zUs7OtLr0QBUkgNbb43F+bjyc+KsZQoFu3xZBbNZ/glE7VSGCUfJbTN8exW6dRAzqkE2dnJESKfBB8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3712 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tudor Ambarus In case of 16-bit Write Status Register, check that both SR1 and SR2 were written correctly. Signed-off-by: Tudor Ambarus --- drivers/mtd/spi-nor/spi-nor.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 55a12a1d710e..eecbd161df25 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2067,6 +2067,7 @@ static int spansion_no_read_cr_quad_enable(struct spi= _nor *nor) { u8 *sr_cr =3D nor->bouncebuf; int ret; + u8 sr_written; =20 /* Keep the current value of the Status Register. */ ret =3D spi_nor_read_sr(nor, &sr_cr[0]); @@ -2075,7 +2076,22 @@ static int spansion_no_read_cr_quad_enable(struct sp= i_nor *nor) =20 sr_cr[1] =3D CR_QUAD_EN_SPAN; =20 - return spi_nor_write_sr(nor, sr_cr, 2); + ret =3D spi_nor_write_sr(nor, sr_cr, 2); + if (ret) + return ret; + + sr_written =3D sr_cr[0]; + + ret =3D spi_nor_read_sr(nor, &sr_cr[0]); + if (ret) + return ret; + + if (sr_cr[0] !=3D sr_written) { + dev_err(nor->dev, "SR1: Read back test failed\n"); + return -EIO; + } + + return 0; } =20 /** @@ -2116,6 +2132,17 @@ static int spansion_read_cr_quad_enable(struct spi_n= or *nor) if (ret) return ret; =20 + sr_written =3D sr_cr[0]; + + ret =3D spi_nor_read_sr(nor, &sr_cr[0]); + if (ret) + return ret; + + if (sr_written !=3D sr_cr[0]) { + dev_err(nor->dev, "SR1: Read back test failed\n"); + return -EIO; + } + sr_written =3D sr_cr[1]; =20 /* Read back and check it. */ --=20 2.9.5