linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	saurav.girepunje@hotmail.com
Subject: Re: [PATCH] fs: kernfs: file.c: Drop the condition with no effect.
Date: Tue, 29 Oct 2019 06:21:21 -0700	[thread overview]
Message-ID: <20191029132121.GK3622521@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20191029095552.GA11561@saurav>

On Tue, Oct 29, 2019 at 03:25:52PM +0530, Saurav Girepunje wrote:
> As the "if" and "else" branch body are identical the condition
> has no effect. So drop the if,else condition.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Nack.  Please read the comment right above.

Thanks.

-- 
tejun

      reply	other threads:[~2019-10-29 13:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29  9:55 [PATCH] fs: kernfs: file.c: Drop the condition with no effect Saurav Girepunje
2019-10-29 13:21 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029132121.GK3622521@devbig004.ftw2.facebook.com \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saurav.girepunje@gmail.com \
    --cc=saurav.girepunje@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).