From: Will Deacon <will@kernel.org>
To: Xiang Zheng <zhengxiang9@huawei.com>
Cc: catalin.marinas@arm.com, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com
Subject: Re: [PATCH v2] arm64: print additional fault message when executing non-exec memory
Date: Tue, 29 Oct 2019 13:36:36 +0000 [thread overview]
Message-ID: <20191029133635.GA12800@willie-the-truck> (raw)
In-Reply-To: <20191029124131.32028-1-zhengxiang9@huawei.com>
On Tue, Oct 29, 2019 at 08:41:31PM +0800, Xiang Zheng wrote:
> When attempting to executing non-executable memory, the fault message
> shows:
>
> Unable to handle kernel read from unreadable memory at virtual address
> ffff802dac469000
>
> This may confuse someone, so add a new fault message for instruction
> abort.
>
> Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
> ---
> arch/arm64/mm/fault.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 9fc6db0bcbad..9adec86d0f8a 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -318,6 +318,8 @@ static void __do_kernel_fault(unsigned long addr, unsigned int esr,
> if (is_el1_permission_fault(addr, esr, regs)) {
> if (esr & ESR_ELx_WNR)
> msg = "write to read-only memory";
> + else if (is_el1_instruction_abort(esr))
> + msg = "execute from non-executable memory";
> else
> msg = "read from unreadable memory";
> } else if (addr < PAGE_SIZE) {
Acked-by: Will Deacon <will@kernel.org>
Will
next prev parent reply other threads:[~2019-10-29 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 12:41 [PATCH v2] arm64: print additional fault message when executing non-exec memory Xiang Zheng
2019-10-29 13:36 ` Will Deacon [this message]
2019-10-29 15:41 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029133635.GA12800@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanghaibin.wang@huawei.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).