From: SAURAV GIREPUNJE <saurav.girepunje@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: pbonzini@redhat.com, rkrcmar@redhat.com,
sean.j.christopherson@intel.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] arch: x86: kvm: mmu.c: use true/false for bool type
Date: Tue, 29 Oct 2019 19:12:46 +0530 [thread overview]
Message-ID: <20191029134246.GA4943@saurav> (raw)
In-Reply-To: <20191029101300.GK4114@hirez.programming.kicks-ass.net>
On Tue, Oct 29, 2019 at 11:13:00AM +0100, Peter Zijlstra wrote:
> On Tue, Oct 29, 2019 at 03:11:04PM +0530, Saurav Girepunje wrote:
> > Use true/false for bool type "dbg" in mmu.c
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> > arch/x86/kvm/mmu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> > index 24c23c66b226..c0b1df69ce0f 100644
> > --- a/arch/x86/kvm/mmu.c
> > +++ b/arch/x86/kvm/mmu.c
> > @@ -68,7 +68,7 @@ enum {
> > #undef MMU_DEBUG
> >
> > #ifdef MMU_DEBUG
> > -static bool dbg = 0;
> > +static bool dbg = true;
>
> You're actually changing the value from false to true. Please, if you
> don't know C, don't touch things.
Hi,
Thanks for your review.
I accept that I have given wrong value "true" to debug variable. It's my bad my typo mistake.
I will make sure that I will not touch your exclusive C code where we can assign 0/1 to a bool variable,
As you have given me a free advice, I also request you to please don't review such small patches from newbie to discourage them.
Regards,
Saurav
next prev parent reply other threads:[~2019-10-29 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 9:41 [PATCH] arch: x86: kvm: mmu.c: use true/false for bool type Saurav Girepunje
2019-10-29 10:13 ` Peter Zijlstra
2019-10-29 13:42 ` SAURAV GIREPUNJE [this message]
2019-10-29 15:44 ` Peter Zijlstra
2019-10-31 6:57 ` SAURAV GIREPUNJE
2019-10-31 10:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029134246.GA4943@saurav \
--to=saurav.girepunje@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=saurav.girepunje@hotmail.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).