linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: gor@linux.ibm.com, borntraeger@de.ibm.com, jpoimboe@redhat.com,
	joe.lawrence@redhat.com, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org, jikos@kernel.org, pmladek@suse.com,
	nstange@suse.de, live-patching@vger.kernel.org
Subject: Re: [PATCH v2 0/3] s390/livepatch: Implement reliable stack tracing for the consistency model
Date: Tue, 29 Oct 2019 17:34:50 +0100	[thread overview]
Message-ID: <20191029163450.GI5646@osiris> (raw)
In-Reply-To: <20191029143904.24051-1-mbenes@suse.cz>

On Tue, Oct 29, 2019 at 03:39:01PM +0100, Miroslav Benes wrote:
> - I tried to use the existing infrastructure as much as possible with
>   one exception. I kept unwind_next_frame_reliable() next to the
>   ordinary unwind_next_frame(). I did not come up with a nice solution
>   how to integrate it. The reliable unwinding is executed on a task
>   stack only, which leads to a nice simplification. My integration
>   attempts only obfuscated the existing unwind_next_frame() which is
>   already not easy to read. Ideas are definitely welcome.

Ah, now I see. So patch 2 seems to be leftover(?). Could you just send
how the result would look like?

I'd really like to have only one function, since some of the sanity
checks you added also make sense for what we already have - so code
would diverge from the beginning.


  parent reply	other threads:[~2019-10-29 16:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 14:39 [PATCH v2 0/3] s390/livepatch: Implement reliable stack tracing for the consistency model Miroslav Benes
2019-10-29 14:39 ` [PATCH v2 1/3] s390/unwind: drop unnecessary code around calling ftrace_graph_ret_addr() Miroslav Benes
2019-10-29 14:39 ` [PATCH v2 2/3] s390/unwind: prepare the unwinding interface for reliable stack traces Miroslav Benes
2019-10-29 14:39 ` [PATCH v2 3/3] s390/livepatch: Implement reliable stack tracing for the consistency model Miroslav Benes
2019-10-29 16:17   ` Heiko Carstens
2019-10-30 10:05     ` Miroslav Benes
2019-10-29 16:34 ` Heiko Carstens [this message]
2019-10-30 10:12   ` [PATCH v2 0/3] " Miroslav Benes
2019-10-31 15:24     ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029163450.GI5646@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=nstange@suse.de \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).