From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0F4CA9EC7 for ; Wed, 30 Oct 2019 21:39:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 736B52067D for ; Wed, 30 Oct 2019 21:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727286AbfJ3Vjv (ORCPT ); Wed, 30 Oct 2019 17:39:51 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46940 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfJ3Vjv (ORCPT ); Wed, 30 Oct 2019 17:39:51 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3EE6B14C6834A; Wed, 30 Oct 2019 14:39:50 -0700 (PDT) Date: Wed, 30 Oct 2019 14:39:49 -0700 (PDT) Message-Id: <20191030.143949.809392632168787466.davem@davemloft.net> To: vivien.didelot@gmail.com Cc: linux-kernel@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/7] net: dsa: list DSA links in the fabric From: David Miller In-Reply-To: <20191028195220.2371843-2-vivien.didelot@gmail.com> References: <20191028195220.2371843-1-vivien.didelot@gmail.com> <20191028195220.2371843-2-vivien.didelot@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Oct 2019 14:39:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Mon, 28 Oct 2019 15:52:14 -0400 > @@ -122,6 +124,29 @@ static struct dsa_port *dsa_tree_find_port_by_node(struct dsa_switch_tree *dst, > return NULL; > } > > +struct dsa_link *dsa_link_touch(struct dsa_port *dp, struct dsa_port *link_dp) > +{ > + struct dsa_switch *ds = dp->ds; > + struct dsa_switch_tree *dst = ds->dst; > + struct dsa_link *dl; Please fix the reverse christmas tree here, two suggestions: struct dsa_switch *ds = dp->ds; struct dsa_switch_tree *dst; struct dsa_link *dl; dst = ds->dst; Or, alternatively, since the dst variable is used only once, get rid of it and change: > + list_add_tail(&dl->list, &dst->rtable); to > + list_add_tail(&dl->list, &ds->dst->rtable);