From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A932DCA9EAE for ; Wed, 30 Oct 2019 01:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85FDA20856 for ; Wed, 30 Oct 2019 01:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbfJ3BCT (ORCPT ); Tue, 29 Oct 2019 21:02:19 -0400 Received: from gate.crashing.org ([63.228.1.57]:57584 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbfJ3BCS (ORCPT ); Tue, 29 Oct 2019 21:02:18 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x9U11JQ0012494; Tue, 29 Oct 2019 20:01:20 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x9U11Hij012492; Tue, 29 Oct 2019 20:01:17 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 29 Oct 2019 20:01:17 -0500 From: Segher Boessenkool To: Kees Cook Cc: Borislav Petkov , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , x86@kernel.org, linux-ia64@vger.kernel.org, Arnd Bergmann , linux-xtensa@linux-xtensa.org, Dave Hansen , Heiko Carstens , linuxppc-dev@lists.ozlabs.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, Rick Edgecombe , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Message-ID: <20191030010117.GJ28442@gate.crashing.org> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> <201910110910.48270FC97@keescook> <20191011162552.GK9749@gate.crashing.org> <20191015165412.GD596@zn.tnic> <201910291414.F29F738B7@keescook> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201910291414.F29F738B7@keescook> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 02:15:39PM -0700, Kees Cook wrote: > On Tue, Oct 15, 2019 at 06:54:13PM +0200, Borislav Petkov wrote: > > On Fri, Oct 11, 2019 at 11:25:52AM -0500, Segher Boessenkool wrote: > > > Names *matter*, internal names doubly so. So why replace a good name with > > > a worse name? Because it is slightly less work for you? > > > > So if we agree on the name "notes" and we decide to rename the other > > arches, this should all be done in a separate patchset anyway, and ontop > > of this one. And I believe Kees wouldn't mind doing it ontop since he's > > gotten his hands dirty already. :-P > > I've added more rationale to patch #1 in the just-sent v3 of this > series. If I still can't convince you Segher, I'm happy to send "patch > 30/29" to do a bulk rename to "notes". Let me know. :) I am still not convinced the worse name is a better name, no :-) But if you don't want to do the work, and instead prefer the much smaller change, that is of course a fine decision. Thank you! (I would be happy with such a 30/29 as well, of course.) Segher