linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: mchehab@kernel.org, robh+dt@kernel.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	c.barrett@framos.com, a.brela@framos.com,
	peter.griffin@linaro.org
Subject: Re: [PATCH v3 2/2] media: i2c: Add IMX296 CMOS image sensor driver
Date: Wed, 30 Oct 2019 10:35:44 +0200	[thread overview]
Message-ID: <20191030083544.GG5017@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20191030062634.GA11637@Mani-XPS-13-9360>

On Wed, Oct 30, 2019 at 11:56:34AM +0530, Manivannan Sadhasivam wrote:
> Hi Sakari,
> 
> Thanks for the review!

You're welcome!

> 
> On Tue, Oct 29, 2019 at 02:13:20PM +0200, Sakari Ailus wrote:
> > Hi Manivannan,
> > 
> > On Fri, Oct 25, 2019 at 11:29:08PM +0530, Manivannan Sadhasivam wrote:

...

> > > +static struct i2c_driver imx296_i2c_driver = {
> > > +	.probe_new  = imx296_probe,
> > > +	.remove = imx296_remove,
> > > +	.driver = {
> > > +		.name  = "imx296",
> > > +		.pm = &imx296_pm_ops,
> > > +		.of_match_table = of_match_ptr(imx296_of_match),
> > 
> > No need for of_match_ptr here.
> > 
> 
> AFAIK, of_match_ptr is needed for !OF case. Else we need to manually add
> #ifdef clut to make it NULL. Does the situation changed now?

ACPI based systems can also make use of the compatible string for matching
drivers with devices through of_match_table. This may sometimes be the most
practical approach. I.e. you don't need ifdefs either.

-- 
Regards,

Sakari Ailus

  reply	other threads:[~2019-10-30  8:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 17:59 [PATCH v3 0/2] Add IMX296 CMOS image sensor support Manivannan Sadhasivam
2019-10-25 17:59 ` [PATCH v3 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Manivannan Sadhasivam
2019-10-28 12:21   ` Sakari Ailus
2019-10-29 22:12     ` Rob Herring
2019-10-30  6:45       ` Manivannan Sadhasivam
2019-10-29 22:09   ` Rob Herring
2019-10-25 17:59 ` [PATCH v3 2/2] media: i2c: Add IMX296 CMOS image sensor driver Manivannan Sadhasivam
2019-10-29 12:13   ` Sakari Ailus
2019-10-30  6:26     ` Manivannan Sadhasivam
2019-10-30  8:35       ` Sakari Ailus [this message]
2019-10-30  9:33         ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191030083544.GG5017@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=a.brela@framos.com \
    --cc=c.barrett@framos.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mchehab@kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).