From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0BFCA9EC6 for ; Wed, 30 Oct 2019 12:01:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC6F2218DE for ; Wed, 30 Oct 2019 12:01:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dwwFFn4m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726710AbfJ3MBP (ORCPT ); Wed, 30 Oct 2019 08:01:15 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35586 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbfJ3MBP (ORCPT ); Wed, 30 Oct 2019 08:01:15 -0400 Received: by mail-pg1-f196.google.com with SMTP id c8so1360571pgb.2 for ; Wed, 30 Oct 2019 05:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pn2SBbNltYyaVGymDbdAPJdCwQZFHAgjh2Z52q+dj1A=; b=dwwFFn4mrIwtWIN6ANiIwElOwApzWsI7v1i7rx0h2QZ+LjebgtOSslaOAb91tjz2W8 pW0K/CNndOdBdaBssesEraMc8rUJYFv03ToPABpl5WVro25hduRcjipHBqXNGX4dVFB5 6OJD1IirtOdZ0wTeDIZdYrJE3V/tVC3xhJuGbMKwuBNtj22daYgkS/mUxtS8CXIHlTaL hR2QEzC4MJ4Ri0K/5yWJwe8j0kGK7ly9qbdAkY1GOyykhTuwLu002sLFVWSCDusWuJzi 109l6LAYkFoxd5FDekLBmo5RpGpFLfPUxlMfkT0Dje7ryXziyzpZa08Y4nrRqquV8S99 Duhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Pn2SBbNltYyaVGymDbdAPJdCwQZFHAgjh2Z52q+dj1A=; b=XbVdHfbupoiVIU0Mw5eR+iH6h2EcF/hFkE85GSAT1giFxxEPwzU5RhB7BxFTYpblRP tmg9VrjsBwT+A9Dtwfhb2G0GueMC8GgIr6hGlaCJi0PySMrhVQJ4GhHGhByvlfuoFwRO kYEAdYdAIkFjmgV+OG2Yywc8kBQ0IFMsFdnS37MGZarGtrujwmVma2wFltclMsNVwmgz rN7RCzF+HgXeuMTebE0sFM6tFN8DJBL9CrdTaDeNumkXR4wYVIdefY3hprnJrq6ywSS8 maAfBEox4Xca+yEZUoI/92bWnRMKEzqlV4Szeifwioyqu3SV6H0BQgz2s7bUIHE6GP3O MK6A== X-Gm-Message-State: APjAAAVavfOwIsKJnTCTQovViLuxJKzAuEYDIAbj9D0ad5rh4imuxZPe TDqD6s6dXEqOzsJM2kCFBo/jpG7bMg== X-Google-Smtp-Source: APXvYqzZ4kqchrmVDuSmUbMpCOHr9OhgeLDhCral1RgOulvxlW5oUWV1FdBYh1NOIHktZhDyzxsfNw== X-Received: by 2002:a17:90b:282:: with SMTP id az2mr13396510pjb.23.1572436874465; Wed, 30 Oct 2019 05:01:14 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:618e:77d9:c9fa:423a:3851:8df4]) by smtp.gmail.com with ESMTPSA id q185sm4328613pfc.153.2019.10.30.05.01.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Oct 2019 05:01:13 -0700 (PDT) Date: Wed, 30 Oct 2019 17:31:05 +0530 From: Manivannan Sadhasivam To: Sakari Ailus Cc: mchehab@kernel.org, robh+dt@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org Subject: Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Message-ID: <20191030120105.GA11432@Mani-XPS-13-9360> References: <20191030094902.32582-1-manivannan.sadhasivam@linaro.org> <20191030094902.32582-2-manivannan.sadhasivam@linaro.org> <20191030115328.GA6253@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030115328.GA6253@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sakari, On Wed, Oct 30, 2019 at 01:53:28PM +0200, Sakari Ailus wrote: > Hi Nabuvannan, > > On Wed, Oct 30, 2019 at 03:19:01PM +0530, Manivannan Sadhasivam wrote: > > Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also > > add MAINTAINERS entry for the binding and driver. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++++++++++++++++++ > > MAINTAINERS | 8 ++ > > 2 files changed, 102 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > > new file mode 100644 > > index 000000000000..c04ec2203268 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > > @@ -0,0 +1,94 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/imx296.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor > > + > > +maintainers: > > + - Manivannan Sadhasivam > > + > > +description: |- > > + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image > > + sensor with square pixel array and 1.58 M effective pixels. This chip > > + features a global shutter with variable charge-integration time. It is > > + programmable through I2C and 4-wire interfaces. The sensor output is > > + available via CSI-2 serial data output (1 Lane). > > + > > +properties: > > + compatible: > > + const: sony,imx296 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + description: > > + Input clock for the sensor. > > + items: > > + - const: mclk > > + > > + clock-frequency: > > + description: > > + Frequency of the mclk clock in Hertz. > > + > > + vddo-supply: > > + description: > > + Definition of the regulator used as interface power supply. > > + > > + vdda-supply: > > + description: > > + Definition of the regulator used as analog power supply. > > + > > + vddd-supply: > > + description: > > + Definition of the regulator used as digital power supply. > > + > > + reset-gpios: > > + description: > > + The phandle and specifier for the GPIO that controls sensor reset. > > + maxItems: 1 > > + > > + port: true > > You're missing "type: object" under port. > I did that intentionally, since there are other places where I can see the "type" field not specified. So, I was not sure about that. Most of the display bindings don't specify "type" and they are most available ones. I don't think the "port" property differs between cameras and displays. So I went with that. Thanks, Mani > -- > Regards, > > Sakari Ailus