* [PATCH] tty: n_hdlc: fix build on SPARC
@ 2019-10-01 2:15 Randy Dunlap
2019-10-30 18:34 ` Kees Cook
2020-01-12 8:05 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Randy Dunlap @ 2019-10-01 2:15 UTC (permalink / raw)
To: LKML, sparclinux
Cc: Andrew Morton, Greg Kroah-Hartman, Kees Cook, David Miller,
kbuild test robot
From: Randy Dunlap <rdunlap@infradead.org>
Fix tty driver build on SPARC by not using __exitdata.
It appears that SPARC does not support section .exit.data.
Fixes these build errors:
`.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
`.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
`.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
`.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 063246641d4a ("format-security: move static strings to const")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
drivers/tty/n_hdlc.c | 5 +++++
1 file changed, 5 insertions(+)
--- mmotm-2019-0925-1810.orig/drivers/tty/n_hdlc.c
+++ mmotm-2019-0925-1810/drivers/tty/n_hdlc.c
@@ -968,6 +968,11 @@ static int __init n_hdlc_init(void)
} /* end of init_module() */
+#ifdef CONFIG_SPARC
+#undef __exitdata
+#define __exitdata
+#endif
+
static const char hdlc_unregister_ok[] __exitdata =
KERN_INFO "N_HDLC: line discipline unregistered\n";
static const char hdlc_unregister_fail[] __exitdata =
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tty: n_hdlc: fix build on SPARC
2019-10-01 2:15 [PATCH] tty: n_hdlc: fix build on SPARC Randy Dunlap
@ 2019-10-30 18:34 ` Kees Cook
2019-10-30 19:29 ` John Paul Adrian Glaubitz
2020-01-12 8:05 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Kees Cook @ 2019-10-30 18:34 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, sparclinux, Andrew Morton, Greg Kroah-Hartman,
David Miller, kbuild test robot
On Mon, Sep 30, 2019 at 07:15:12PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix tty driver build on SPARC by not using __exitdata.
> It appears that SPARC does not support section .exit.data.
>
> Fixes these build errors:
>
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 063246641d4a ("format-security: move static strings to const")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Wow. That commit is from 2.5 years ago. Is the SPARC port still alive?
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> drivers/tty/n_hdlc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- mmotm-2019-0925-1810.orig/drivers/tty/n_hdlc.c
> +++ mmotm-2019-0925-1810/drivers/tty/n_hdlc.c
> @@ -968,6 +968,11 @@ static int __init n_hdlc_init(void)
>
> } /* end of init_module() */
>
> +#ifdef CONFIG_SPARC
> +#undef __exitdata
> +#define __exitdata
> +#endif
Shouldn't this be somewhere else? Any other driver wanting to use
__exitdata would need a similar patch. This feels like it should be
handled where __exitdata is normally defined?
-Kees
> +
> static const char hdlc_unregister_ok[] __exitdata =
> KERN_INFO "N_HDLC: line discipline unregistered\n";
> static const char hdlc_unregister_fail[] __exitdata =
>
>
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tty: n_hdlc: fix build on SPARC
2019-10-30 18:34 ` Kees Cook
@ 2019-10-30 19:29 ` John Paul Adrian Glaubitz
2019-10-30 19:49 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: John Paul Adrian Glaubitz @ 2019-10-30 19:29 UTC (permalink / raw)
To: Kees Cook, Randy Dunlap
Cc: LKML, sparclinux, Andrew Morton, Greg Kroah-Hartman,
David Miller, kbuild test robot
On 10/30/19 7:34 PM, Kees Cook wrote:
> On Mon, Sep 30, 2019 at 07:15:12PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix tty driver build on SPARC by not using __exitdata.
>> It appears that SPARC does not support section .exit.data.
>>
>> Fixes these build errors:
>>
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>>
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Fixes: 063246641d4a ("format-security: move static strings to const")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Wow. That commit is from 2.5 years ago. Is the SPARC port still alive?
Yes, it is. No idea why we didn't run into this. I assume it affects certain
configurations only. On Debian, we are always compiling and running the
latest kernel versions on sparc64.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tty: n_hdlc: fix build on SPARC
2019-10-30 19:29 ` John Paul Adrian Glaubitz
@ 2019-10-30 19:49 ` Kees Cook
0 siblings, 0 replies; 6+ messages in thread
From: Kees Cook @ 2019-10-30 19:49 UTC (permalink / raw)
To: John Paul Adrian Glaubitz
Cc: Randy Dunlap, LKML, sparclinux, Andrew Morton,
Greg Kroah-Hartman, David Miller, kbuild test robot
On Wed, Oct 30, 2019 at 08:29:40PM +0100, John Paul Adrian Glaubitz wrote:
> On 10/30/19 7:34 PM, Kees Cook wrote:
> > On Mon, Sep 30, 2019 at 07:15:12PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@infradead.org>
> >>
> >> Fix tty driver build on SPARC by not using __exitdata.
> >> It appears that SPARC does not support section .exit.data.
> >>
> >> Fixes these build errors:
> >>
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >>
> >> Reported-by: kbuild test robot <lkp@intel.com>
> >> Fixes: 063246641d4a ("format-security: move static strings to const")
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Wow. That commit is from 2.5 years ago. Is the SPARC port still alive?
> Yes, it is. No idea why we didn't run into this. I assume it affects certain
> configurations only. On Debian, we are always compiling and running the
> latest kernel versions on sparc64.
Yeah, that's what I thought. I also didn't hit it 2.5 years ago when I
did multi-architecture build validation of these changes. :P
Randy you've found a nice corner case! :)
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tty: n_hdlc: fix build on SPARC
2019-10-01 2:15 [PATCH] tty: n_hdlc: fix build on SPARC Randy Dunlap
2019-10-30 18:34 ` Kees Cook
@ 2020-01-12 8:05 ` David Miller
2020-01-12 16:11 ` Randy Dunlap
1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2020-01-12 8:05 UTC (permalink / raw)
To: rdunlap; +Cc: linux-kernel, sparclinux, akpm, gregkh, keescook, lkp
From: Randy Dunlap <rdunlap@infradead.org>
Date: Mon, 30 Sep 2019 19:15:12 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix tty driver build on SPARC by not using __exitdata.
> It appears that SPARC does not support section .exit.data.
>
> Fixes these build errors:
>
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 063246641d4a ("format-security: move static strings to const")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
I'll add an .exit.data to arch/sparc/kernel/vmlinux.lds.S to fix this.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tty: n_hdlc: fix build on SPARC
2020-01-12 8:05 ` David Miller
@ 2020-01-12 16:11 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2020-01-12 16:11 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, sparclinux, akpm, gregkh, keescook, lkp
On 1/12/20 12:05 AM, David Miller wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> Date: Mon, 30 Sep 2019 19:15:12 -0700
>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix tty driver build on SPARC by not using __exitdata.
>> It appears that SPARC does not support section .exit.data.
>>
>> Fixes these build errors:
>>
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>>
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Fixes: 063246641d4a ("format-security: move static strings to const")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> I'll add an .exit.data to arch/sparc/kernel/vmlinux.lds.S to fix this.
>
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-12 16:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 2:15 [PATCH] tty: n_hdlc: fix build on SPARC Randy Dunlap
2019-10-30 18:34 ` Kees Cook
2019-10-30 19:29 ` John Paul Adrian Glaubitz
2019-10-30 19:49 ` Kees Cook
2020-01-12 8:05 ` David Miller
2020-01-12 16:11 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).