* [PATCH -next] gpu: host1x: Fix compile test failure
@ 2019-10-30 13:54 YueHaibing
2019-10-30 22:26 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2019-10-30 13:54 UTC (permalink / raw)
To: thierry.reding, mperttunen, arnd, seanpaul
Cc: dri-devel, linux-tegra, linux-kernel, YueHaibing
If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
COMPILE_TEST is y, building fails:
drivers/gpu/host1x/dev.o: In function `host1x_remove':
dev.c:(.text+0x624): undefined reference to `put_iova_domain'
dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/host1x/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index cf987a3..354232d 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -2,7 +2,7 @@
config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
- select IOMMU_IOVA if IOMMU_SUPPORT
+ select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
help
Driver for the NVIDIA Tegra host1x hardware.
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] gpu: host1x: Fix compile test failure
2019-10-30 13:54 [PATCH -next] gpu: host1x: Fix compile test failure YueHaibing
@ 2019-10-30 22:26 ` Dmitry Osipenko
2019-10-31 13:33 ` Yuehaibing
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Osipenko @ 2019-10-30 22:26 UTC (permalink / raw)
To: YueHaibing, thierry.reding, mperttunen, arnd, seanpaul
Cc: dri-devel, linux-tegra, linux-kernel
30.10.2019 16:54, YueHaibing пишет:
> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
> COMPILE_TEST is y, building fails:
>
> drivers/gpu/host1x/dev.o: In function `host1x_remove':
> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
>
> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/host1x/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index cf987a3..354232d 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -2,7 +2,7 @@
> config TEGRA_HOST1X
> tristate "NVIDIA Tegra host1x driver"
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> - select IOMMU_IOVA if IOMMU_SUPPORT
> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
> help
> Driver for the NVIDIA Tegra host1x hardware.
>
>
It should be better to unconditionally select IOMMU_IOVA here.
The same could be done for drivers/staging/media/tegra-vde/ and
drivers/gpu/host1x/, please see [1].
[1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] gpu: host1x: Fix compile test failure
2019-10-30 22:26 ` Dmitry Osipenko
@ 2019-10-31 13:33 ` Yuehaibing
2019-10-31 15:41 ` Dmitry Osipenko
2019-11-01 9:47 ` Thierry Reding
0 siblings, 2 replies; 6+ messages in thread
From: Yuehaibing @ 2019-10-31 13:33 UTC (permalink / raw)
To: Dmitry Osipenko, thierry.reding, mperttunen, arnd, seanpaul
Cc: dri-devel, linux-tegra, linux-kernel
On 2019/10/31 6:26, Dmitry Osipenko wrote:
> 30.10.2019 16:54, YueHaibing пишет:
>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
>> COMPILE_TEST is y, building fails:
>>
>> drivers/gpu/host1x/dev.o: In function `host1x_remove':
>> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
>> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
>> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
>> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
>>
>> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/gpu/host1x/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
>> index cf987a3..354232d 100644
>> --- a/drivers/gpu/host1x/Kconfig
>> +++ b/drivers/gpu/host1x/Kconfig
>> @@ -2,7 +2,7 @@
>> config TEGRA_HOST1X
>> tristate "NVIDIA Tegra host1x driver"
>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>> - select IOMMU_IOVA if IOMMU_SUPPORT
>> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
>> help
>> Driver for the NVIDIA Tegra host1x hardware.
>>
>>
>
> It should be better to unconditionally select IOMMU_IOVA here.
>
> The same could be done for drivers/staging/media/tegra-vde/ and
> drivers/gpu/host1x/, please see [1].
Yep, I will repost, thanks!
>
> [1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] gpu: host1x: Fix compile test failure
2019-10-31 13:33 ` Yuehaibing
@ 2019-10-31 15:41 ` Dmitry Osipenko
2019-11-01 9:47 ` Thierry Reding
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2019-10-31 15:41 UTC (permalink / raw)
To: Yuehaibing, thierry.reding, mperttunen, arnd, seanpaul
Cc: dri-devel, linux-tegra, linux-kernel
31.10.2019 16:33, Yuehaibing пишет:
> On 2019/10/31 6:26, Dmitry Osipenko wrote:
>> 30.10.2019 16:54, YueHaibing пишет:
>>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
>>> COMPILE_TEST is y, building fails:
>>>
>>> drivers/gpu/host1x/dev.o: In function `host1x_remove':
>>> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
>>> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
>>> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
>>> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
>>>
>>> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>> drivers/gpu/host1x/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
>>> index cf987a3..354232d 100644
>>> --- a/drivers/gpu/host1x/Kconfig
>>> +++ b/drivers/gpu/host1x/Kconfig
>>> @@ -2,7 +2,7 @@
>>> config TEGRA_HOST1X
>>> tristate "NVIDIA Tegra host1x driver"
>>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>>> - select IOMMU_IOVA if IOMMU_SUPPORT
>>> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
>>> help
>>> Driver for the NVIDIA Tegra host1x hardware.
>>>
>>>
>>
>> It should be better to unconditionally select IOMMU_IOVA here.
>>
>> The same could be done for drivers/staging/media/tegra-vde/ and
>> drivers/gpu/host1x/, please see [1].
>
> Yep, I will repost, thanks!
Oh, I missed that you made a patch for host1x and not for drm. Thus
drivers/gpu/drm/tegra/ also needs the same change.
>>
>> [1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] gpu: host1x: Fix compile test failure
2019-10-31 13:33 ` Yuehaibing
2019-10-31 15:41 ` Dmitry Osipenko
@ 2019-11-01 9:47 ` Thierry Reding
2019-11-01 11:33 ` Yuehaibing
1 sibling, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2019-11-01 9:47 UTC (permalink / raw)
To: Yuehaibing
Cc: Dmitry Osipenko, mperttunen, arnd, seanpaul, dri-devel,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1855 bytes --]
On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote:
> On 2019/10/31 6:26, Dmitry Osipenko wrote:
> > 30.10.2019 16:54, YueHaibing пишет:
> >> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
> >> COMPILE_TEST is y, building fails:
> >>
> >> drivers/gpu/host1x/dev.o: In function `host1x_remove':
> >> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
> >> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
> >> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
> >> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
> >>
> >> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
> >>
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >> drivers/gpu/host1x/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> >> index cf987a3..354232d 100644
> >> --- a/drivers/gpu/host1x/Kconfig
> >> +++ b/drivers/gpu/host1x/Kconfig
> >> @@ -2,7 +2,7 @@
> >> config TEGRA_HOST1X
> >> tristate "NVIDIA Tegra host1x driver"
> >> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> >> - select IOMMU_IOVA if IOMMU_SUPPORT
> >> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
> >> help
> >> Driver for the NVIDIA Tegra host1x hardware.
> >>
> >>
> >
> > It should be better to unconditionally select IOMMU_IOVA here.
> >
> > The same could be done for drivers/staging/media/tegra-vde/ and
> > drivers/gpu/host1x/, please see [1].
>
> Yep, I will repost, thanks!
No need to resend, I already have patches for that.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] gpu: host1x: Fix compile test failure
2019-11-01 9:47 ` Thierry Reding
@ 2019-11-01 11:33 ` Yuehaibing
0 siblings, 0 replies; 6+ messages in thread
From: Yuehaibing @ 2019-11-01 11:33 UTC (permalink / raw)
To: Thierry Reding
Cc: Dmitry Osipenko, mperttunen, arnd, seanpaul, dri-devel,
linux-tegra, linux-kernel
On 2019/11/1 17:47, Thierry Reding wrote:
> On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote:
>> On 2019/10/31 6:26, Dmitry Osipenko wrote:
>>> 30.10.2019 16:54, YueHaibing пишет:
>>>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
>>>> COMPILE_TEST is y, building fails:
>>>>
>>>> drivers/gpu/host1x/dev.o: In function `host1x_remove':
>>>> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
>>>> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
>>>> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
>>>> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
>>>>
>>>> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
>>>>
>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
>>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>>> ---
>>>> drivers/gpu/host1x/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
>>>> index cf987a3..354232d 100644
>>>> --- a/drivers/gpu/host1x/Kconfig
>>>> +++ b/drivers/gpu/host1x/Kconfig
>>>> @@ -2,7 +2,7 @@
>>>> config TEGRA_HOST1X
>>>> tristate "NVIDIA Tegra host1x driver"
>>>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>>>> - select IOMMU_IOVA if IOMMU_SUPPORT
>>>> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
>>>> help
>>>> Driver for the NVIDIA Tegra host1x hardware.
>>>>
>>>>
>>>
>>> It should be better to unconditionally select IOMMU_IOVA here.
>>>
>>> The same could be done for drivers/staging/media/tegra-vde/ and
>>> drivers/gpu/host1x/, please see [1].
>>
>> Yep, I will repost, thanks!
>
> No need to resend, I already have patches for that.
Ok, thanks!
>
> Thierry
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-01 11:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 13:54 [PATCH -next] gpu: host1x: Fix compile test failure YueHaibing
2019-10-30 22:26 ` Dmitry Osipenko
2019-10-31 13:33 ` Yuehaibing
2019-10-31 15:41 ` Dmitry Osipenko
2019-11-01 9:47 ` Thierry Reding
2019-11-01 11:33 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).