From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161EECA9EC6 for ; Wed, 30 Oct 2019 16:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB002208E3 for ; Wed, 30 Oct 2019 16:30:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xiVSPGDx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbfJ3Qaq (ORCPT ); Wed, 30 Oct 2019 12:30:46 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38754 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbfJ3Qaq (ORCPT ); Wed, 30 Oct 2019 12:30:46 -0400 Received: by mail-pf1-f196.google.com with SMTP id c13so1941341pfp.5 for ; Wed, 30 Oct 2019 09:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=frY6rw5HiV1E5VHgu13X5DYK6Y+AvDh4NtUT+hC+PqI=; b=xiVSPGDxmxZceTHX1TwbfKwSgrTnCXP1keP3yqLhCb2QykhTGMfAISQG0TV7mFhF+P aQEvPOX5/IvbMuwfcTeAfQsMyfpgq0qiKArAolTyu6qrvi05TOxS6g3gO7mhmaPqXp/F W1sD2dXJ3M9Y4HA0CJzYRFjL4gaQoo8r7h84OuAUvMHITOH9XX5jZGRMCZiVakWLGaoc XF2PDT4UISxQWOkJCTQnMNhbfUx2sjXBfH3zxLnIrgn1U/BpjpLmoumfFIUcRYGp7/Bn vQokEpZUa9jq9ARePC+qprFT1pUjfS8Su6HSkYELXXWb0rvseVFb1dPnh3wp6q4Eso/C hs+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=frY6rw5HiV1E5VHgu13X5DYK6Y+AvDh4NtUT+hC+PqI=; b=P9GUPru+pR4JjB/XZxjavhYnxDrxLpD4hiPh9pZ5EFDjOvbq5p3HFB8msW5I2Bizja QZA+RKkNLwIcCN6CU5VVmmHODSplgUKVD4gzmnv3LWEQbPnmuERJJ/2/4oFlrKJl3dKQ VIxCF+eLjjySC2plgyAhCnM2rTZMG/zAVji8p1GQ10k4SE7jbX6yIrvwDuRPPxd1xDpD 2DmV1V5pxoRyrAe0Uq+A/qSpFyotKfuAJF2f4+Fq68nEtr+9LFCrm/eo7S81VEhricKS OYkjz2oKhXPM4FpFT4fSUf83gWtMiABgVhOUUGJFt8QAH3palQBA1gcqHtbNemU8Nn4w 6acg== X-Gm-Message-State: APjAAAUOlVBS1+IcaQr6VjkqqTUYtONjcmcFZZ8mA7RgeTcIO3oEo+ue G3HhtFn/OZrCgAcMd3FldDBSLqt9yx4= X-Google-Smtp-Source: APXvYqxGP0mpS9c5+JBz15CTK6yxsgrFNZFBJzidVG93iroVyV1o1u9ByvmoY2tHDbIZRN1EQwda6Q== X-Received: by 2002:a62:5442:: with SMTP id i63mr151097pfb.220.1572453045057; Wed, 30 Oct 2019 09:30:45 -0700 (PDT) Received: from localhost.localdomain (c-67-170-172-113.hsd1.or.comcast.net. [67.170.172.113]) by smtp.gmail.com with ESMTPSA id o1sm388483pgm.1.2019.10.30.09.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 09:30:44 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Colin King , Sumit Semwal , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , "Andrew F . Davis" , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org Subject: [PATCH] dma-buf: heaps: Fix redundant assignment to variable ret in system_heap.c Date: Wed, 30 Oct 2019 16:30:40 +0000 Message-Id: <20191030163040.70055-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King reported a coverity error: The variable ret is being assigned with a value that is never read, it is being re-assigned the same value on the err0 exit path. The assignment is redundant and hence can be removed. He had a fix, but Andrew Davis suggested a better solution (actually returning ret), so this patch implements that fix. Cc: Colin King Cc: Sumit Semwal Cc: Benjamin Gaignard Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Andrew F. Davis Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-sig@lists.linaro.org Cc: kernel-janitors@vger.kernel.org Addresses-Coverity: ("Unused value") Fixes: 47a32f9c1226 ("dma-buf: heaps: Add system heap to dmabuf heaps") Reported-by: Colin Ian King Suggested-by: Andrew F. Davis Signed-off-by: John Stultz --- drivers/dma-buf/heaps/system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index 455782efbb32..9a56393e40b4 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -98,7 +98,7 @@ static int system_heap_allocate(struct dma_heap *heap, err0: kfree(helper_buffer); - return -ENOMEM; + return ret; } static const struct dma_heap_ops system_heap_ops = { -- 2.17.1