linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benoit Parrot <bparrot@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
	<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [Patch 1/3] ARM: dts: am43xx: add support for clkout1 clock
Date: Wed, 30 Oct 2019 14:59:47 -0500	[thread overview]
Message-ID: <20191030195946.ouexmis632nb7lqj@ti.com> (raw)
In-Reply-To: <20191023155657.GL5610@atomide.com>

Tony Lindgren <tony@atomide.com> wrote on Wed [2019-Oct-23 08:56:57 -0700]:
> * Tony Lindgren <tony@atomide.com> [191022 16:56]:
> > * Tero Kristo <t-kristo@ti.com> [191022 16:48]:
> > > On 22/10/2019 19:21, Benoit Parrot wrote:
> > > > Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 08:48:16 -0700]:
> > > > > * Benoit Parrot <bparrot@ti.com> [191016 18:47]:
> > > > > > --- a/arch/arm/boot/dts/am43xx-clocks.dtsi
> > > > > > +++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
> > > > > > @@ -704,6 +704,60 @@
> > > > > >   		ti,bit-shift = <8>;
> > > > > >   		reg = <0x2a48>;
> > > > > >   	};
> > > > > > +
> > > > > > +	clkout1_osc_div_ck: clkout1_osc_div_ck {
> > > > > > +		#clock-cells = <0>;
> > > > > > +		compatible = "ti,divider-clock";
> > > > > > +		clocks = <&sys_clkin_ck>;
> > > > > > +		ti,bit-shift = <20>;
> > > > > > +		ti,max-div = <4>;
> > > > > > +		reg = <0x4100>;
> > > > > > +	};
> > > > > 
> > > > > Here too please describe why the clock names are not generic.
> > > > 
> > > > Tero originally had this patch in the kernel so this is somewhat of a
> > > > revert. Since these "clock" were removed. If the name syntax is no longer
> > > > valid for some reason, then I will need a little more informations to
> > > > proceed.
> > > > 
> > > > Tero, can you assist here?
> > > 
> > > This one is just following the naming convention of the rest of the clocks
> > > atm.
> > > 
> > > If we need to fix all the underscore name clocks, that requires pretty much
> > > complete revamp of both the dts data + clock data under the clock driver,
> > > and it is not backwards compatible either. How should we tackle that one?
> > > 
> > > We could maybe add support code in kernel to do s/-/_/g for the "new" clocks
> > > so that their parent-child relationships would be retained, and then convert
> > > the clocks in phases.
> > 
> > Well some of them can be fixed by configuring things based
> > on the compatible value and then the node name can be just
> > clock like it should be.
> > 
> > Here too one option would be to add custom compatibles like:
> > 
> > compatible = "ti,clkout1-osc-div", "ti,divider-clock";
> > 
> > And then have match data configure the rest.
> > 
> > The other option would be to have lookup tables in the clock
> > driver based on the SoC and reg address.
> > 
> > This is a hidden mine though.. We've hit it already several times,
> > and any dts clean-up effort has a chance of breaking things.
> 
> Hmm maybe in this case just doing this is enough:
> 
> clkout1_osc_div_ck: clock@4100 {
> 	... 
> }

But then we would end up with 6 clock node with the same name "clock@4100",
doesn't pose a problem somewhere?

Tero?

Benoit

> 
> Or do all the TI clocks we have have a dependency to the
> node naming?
> 
> Regards,
> 
> Tony
> 

  reply	other threads:[~2019-10-30 20:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 18:49 [Patch 0/3] ARM: dts: am43x-vpfe/ov2659.patch Benoit Parrot
2019-10-16 18:49 ` [Patch 1/3] ARM: dts: am43xx: add support for clkout1 clock Benoit Parrot
2019-10-22 15:48   ` Tony Lindgren
2019-10-22 16:21     ` Benoit Parrot
2019-10-22 16:47       ` Tero Kristo
2019-10-22 16:55         ` Tony Lindgren
2019-10-23 15:56           ` Tony Lindgren
2019-10-30 19:59             ` Benoit Parrot [this message]
2019-10-31 14:06               ` Tero Kristo
2019-10-31 14:25                 ` Tony Lindgren
2019-10-16 18:49 ` [Patch 2/3] ARM: dts: am437x-sk-evm: Add VPFE and OV2659 entries Benoit Parrot
2019-10-16 18:49 ` [Patch 3/3] ARM: dts: am43x-epos-evm: " Benoit Parrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191030195946.ouexmis632nb7lqj@ti.com \
    --to=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).