From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26645CA9EC3 for ; Thu, 31 Oct 2019 11:05:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0375A20862 for ; Thu, 31 Oct 2019 11:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727366AbfJaLFW (ORCPT ); Thu, 31 Oct 2019 07:05:22 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46804 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbfJaLFW (ORCPT ); Thu, 31 Oct 2019 07:05:22 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id A672F28A49B; Thu, 31 Oct 2019 11:05:20 +0000 (GMT) Date: Thu, 31 Oct 2019 12:05:18 +0100 From: Boris Brezillon To: Cc: , , , , Subject: Re: [PATCH v3 13/32] mtd: spi-nor: Print error messages inside Reg Ops methods Message-ID: <20191031120518.5bac1caa@collabora.com> In-Reply-To: <20191029111615.3706-14-tudor.ambarus@microchip.com> References: <20191029111615.3706-1-tudor.ambarus@microchip.com> <20191029111615.3706-14-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Oct 2019 11:17:09 +0000 wrote: > From: Tudor Ambarus > > Spare the callers of printing error messages by themselves. > > Signed-off-by: Tudor Ambarus > --- > drivers/mtd/spi-nor/spi-nor.c | 165 +++++++++++++++++++++++++++++++----------- > 1 file changed, 123 insertions(+), 42 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index e5ed9012cd50..bc46b946ac77 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -394,6 +394,8 @@ static ssize_t spi_nor_write_data(struct spi_nor *nor, loff_t to, size_t len, > */ > static int spi_nor_write_enable(struct spi_nor *nor) > { > + int ret; > + > if (nor->spimem) { > struct spi_mem_op op = > SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WREN, 1), > @@ -401,10 +403,16 @@ static int spi_nor_write_enable(struct spi_nor *nor) > SPI_MEM_OP_NO_DUMMY, > SPI_MEM_OP_NO_DATA); > > - return spi_mem_exec_op(nor->spimem, &op); > + ret = spi_mem_exec_op(nor->spimem, &op); > + } else { > + ret = nor->controller_ops->write_reg(nor, SPINOR_OP_WREN, > + NULL, 0); > } > > - return nor->controller_ops->write_reg(nor, SPINOR_OP_WREN, NULL, 0); > + if (ret) > + dev_err(nor->dev, "error %d on Write Enable\n", ret); I thought we agreed on using dev_err_once() here (applies to other dev_err() calls). If it fails once it's unlikely to succeed on subsequent calls, and I don't think spamming the kernel logs is very useful. > + > + return ret; > }