From: Al Viro <viro@zeniv.linux.org.uk>
To: Yi Li <yili@winhong.com>
Cc: linux-fsdevel@vger.kernel.org, Yi Li <yilikernel@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seq_file: fix condition while loop
Date: Thu, 31 Oct 2019 14:06:00 +0000 [thread overview]
Message-ID: <20191031140600.GL26530@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1572521901-5070-1-git-send-email-yili@winhong.com>
On Thu, Oct 31, 2019 at 07:38:21PM +0800, Yi Li wrote:
> From: Yi Li <yilikernel@gmail.com>
>
> Use the break condition of loop body.
> PTR_ERR has some meanings when p is illegal,and return 0 when p is null.
> set the err = 0 on the next iteration if err > 0.
IDGI. PTR_ERR() is not going to cause any kind of undefined behaviour for
any valid pointer and it's trivial to evaluate. What's the point?
next prev parent reply other threads:[~2019-10-31 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 11:38 [PATCH] seq_file: fix condition while loop Yi Li
2019-10-31 14:06 ` Al Viro [this message]
2019-11-01 5:48 ` 李义
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031140600.GL26530@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yili@winhong.com \
--cc=yilikernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).