From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A0B8CA9ECB for ; Thu, 31 Oct 2019 15:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D36AD208C0 for ; Thu, 31 Oct 2019 15:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572536165; bh=AbvQStO4mftxwOLZ6Vl8wEv4VUDwqs8YdcH3DMqFFYs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zt+vFUUFNr9mvuz+xq3iI6LRw6LVEgQOsUDawjw59cPfoUveL2M0O6nyTqWim8tfM 9cz1dfhxEhPByVQGz3o3GyxT+U4sLrPLPx+N2zylGdYGl33i6aR4PVHfIFIkPcEImr lHblN8+cfPqHFYM3h19/6Uw8anj3mA5scHFgerCU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728288AbfJaPgE (ORCPT ); Thu, 31 Oct 2019 11:36:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:49142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbfJaPgE (ORCPT ); Thu, 31 Oct 2019 11:36:04 -0400 Received: from localhost (unknown [91.217.168.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BD632086D; Thu, 31 Oct 2019 15:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572536163; bh=AbvQStO4mftxwOLZ6Vl8wEv4VUDwqs8YdcH3DMqFFYs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SgK0nkFL/OFf39EmgXyG/cwq07tF9zrAreYfzEZ96SVGFKha6hnCKad0/aaVbdJ+l DiTmvprYSSf1qmHgsy1CNs0dW2uNwTc9ki2AMyLcuQEeTQDVdiqNYznTyttAYf6SQZ Ug1rsN0rcIK7euU0dn26eb8hJ6iD4r6Fbi52ufKg= Date: Thu, 31 Oct 2019 11:36:00 -0400 From: Sasha Levin To: Lakshmi Ramasubramanian Cc: zohar@linux.ibm.com, dhowells@redhat.com, matthewgarrett@google.com, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, prsriva@linux.microsoft.com Subject: Re: [PATCH v3 1/9] KEYS: Defined an IMA hook to measure keys on key create or update Message-ID: <20191031153600.GR1554@sasha-vm> References: <20191031011910.2574-1-nramas@linux.microsoft.com> <20191031011910.2574-2-nramas@linux.microsoft.com> <20191031091041.GO1554@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 08:27:47AM -0700, Lakshmi Ramasubramanian wrote: >On 10/31/19 2:10 AM, Sasha Levin wrote: > >Hi Sasha, > >>On Wed, Oct 30, 2019 at 06:19:02PM -0700, Lakshmi Ramasubramanian wrote: >>>Asymmetric keys used for verifying file signatures or certificates >>>are currently not included in the IMA measurement list. >>> >>>This patch defines a new IMA hook namely ima_post_key_create_or_update() >>>to measure asymmetric keys. >>> >>>Signed-off-by: Lakshmi Ramasubramanian >> >>What are the prerequisites for this patch? > >I built this patch set on kernel v5.3 > >I applied the following patch provided by Nayna Jain@IBM and then >added my changes: > > [PATCH v9 5/8] ima: make process_buffer_measurement() generic $ git checkout v5.3 HEAD is now at 4d856f72c10ec Linux 5.3 $ git am ~/incoming/_PATCH_v9_5-8_ima_make_process_buffer_measurement__generic.patch Applying: ima: make process_buffer_measurement() generic error: patch failed: security/integrity/ima/ima.h:217 error: security/integrity/ima/ima.h: patch does not apply What am I missing? -- Thanks, Sasha