From: Lee Jones <lee.jones@linaro.org>
To: daniel.thompson@linaro.org, broonie@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
linus.walleij@linaro.org, baohua@kernel.org, stephan@gerhold.net,
Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v4 00/10] Simplify MFD Core
Date: Fri, 1 Nov 2019 07:45:08 +0000 [thread overview]
Message-ID: <20191101074518.26228-1-lee.jones@linaro.org> (raw)
MFD currently has one over-complicated user. CS5535 uses a mixture of
cell cloning, reference counting and subsystem-level call-backs to
achieve its goal of requesting an IO memory region only once across 3
consumers. The same can be achieved by handling the region centrally
during the parent device's .probe() sequence. Releasing can be handed
in a similar way during .remove().
While we're here, take the opportunity to provide some clean-ups and
error checking to issues noticed along the way.
This also paves the way for clean cell disabling via Device Tree being
discussed at [0].
[0] https://lkml.org/lkml/2019/10/18/612.
Lee Jones (10):
mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message
mfd: cs5535-mfd: Remove mfd_cell->id hack
mfd: cs5535-mfd: Request shared IO regions centrally
mfd: cs5535-mfd: Register clients using their own dedicated MFD cell
entries
mfd: mfd-core: Protect against NULL call-back function pointer
mfd: mfd-core: Remove mfd_clone_cell()
x86: olpc-xo1-pm: Remove invocation of MFD's .enable()/.disable()
call-backs
x86: olpc-xo1-sci: Remove invocation of MFD's .enable()/.disable()
call-backs
mfd: mfd-core: Remove usage counting for .{en,dis}able() call-backs
mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device()
arch/x86/platform/olpc/olpc-xo1-pm.c | 8 --
arch/x86/platform/olpc/olpc-xo1-sci.c | 6 --
drivers/mfd/cs5535-mfd.c | 108 +++++++++++-------------
drivers/mfd/mfd-core.c | 113 +++++---------------------
include/linux/mfd/core.h | 20 -----
5 files changed, 68 insertions(+), 187 deletions(-)
--
2.17.1
next reply other threads:[~2019-11-01 7:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 7:45 Lee Jones [this message]
2019-11-01 7:45 ` [PATCH v4 01/10] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message Lee Jones
2019-11-01 7:45 ` [PATCH v4 02/10] mfd: cs5535-mfd: Remove mfd_cell->id hack Lee Jones
2019-11-01 7:45 ` [PATCH v4 03/10] mfd: cs5535-mfd: Request shared IO regions centrally Lee Jones
2019-11-01 8:01 ` Daniel Thompson
2019-11-01 7:45 ` [PATCH v4 04/10] mfd: cs5535-mfd: Register clients using their own dedicated MFD cell entries Lee Jones
2019-11-01 7:45 ` [PATCH v4 05/10] mfd: mfd-core: Protect against NULL call-back function pointer Lee Jones
2019-11-01 7:45 ` [PATCH v4 06/10] mfd: mfd-core: Remove mfd_clone_cell() Lee Jones
2019-11-01 7:45 ` [PATCH v4 07/10] x86: olpc-xo1-pm: Remove invocation of MFD's .enable()/.disable() call-backs Lee Jones
2019-11-01 7:45 ` [PATCH v4 08/10] x86: olpc-xo1-sci: " Lee Jones
2019-11-01 7:45 ` [PATCH v4 09/10] mfd: mfd-core: Remove usage counting for .{en,dis}able() call-backs Lee Jones
2019-11-01 7:45 ` [PATCH v4 10/10] mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101074518.26228-1-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=baohua@kernel.org \
--cc=broonie@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).