linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>,
	<jic23@kernel.org>, <dragos.bogdan@analog.com>,
	Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH 00/10] iio: adis: cleanups and fixes
Date: Fri, 1 Nov 2019 11:34:55 +0200	[thread overview]
Message-ID: <20191101093505.9408-1-alexandru.ardelean@analog.com> (raw)

This patch-set addresses some issues, where [when making the functions
inline], the GCC [especially for x86_64] compilers start to report
`-Wmaybe-unitialized` warnings/errors.

The warnings are valid from a general stand-point, but are also
false-positives, as the ADIS read functions return 0 or negative values. So
for most cases `ret < 0` is fine [as is done in many drivers].

To appease the compiler, this changeset converts
 `if (ret < 0)` -> `if (ret)` [which is also a valid check]

There are also 2 checkpatch complaints addressed.

And lastly, 3 minor fixes. In some cases, the value of the ADIS read
function should be checked for 0 (success) and only then assign the read
buffer/value. These also contain Fixes tags.

Alexandru Ardelean (10):
  iio: gyro: adis16136: check ret val for non-zero vs less-than-zero
  iio: imu: adis16400: check ret val for non-zero vs less-than-zero
  iio: imu: adis16460: check ret val for non-zero vs less-than-zero
  iio: imu: adis16480: check ret val for non-zero vs less-than-zero
  iio: imu: adis: check ret val for non-zero vs less-than-zero
  iio: imu: adis16480: fix indentation of return statement
  iio: imu: adis16480: prefer `unsigned int` over `unsigned`
  iio: imu: adis16480: assign bias value only if operation succeeded
  iio: imu: adis: assign read val in debugfs hook only if op successful
  iio: imu: adis: assign value only if return code zero in read funcs

 drivers/iio/gyro/adis16136.c | 24 +++++++++++------------
 drivers/iio/imu/adis.c       |  5 +++--
 drivers/iio/imu/adis16400.c  | 22 ++++++++++-----------
 drivers/iio/imu/adis16460.c  |  8 ++++----
 drivers/iio/imu/adis16480.c  | 38 +++++++++++++++++++-----------------
 include/linux/iio/imu/adis.h |  6 ++++--
 6 files changed, 54 insertions(+), 49 deletions(-)

-- 
2.20.1


             reply	other threads:[~2019-11-01  9:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01  9:34 Alexandru Ardelean [this message]
2019-11-01  9:34 ` [PATCH 01/10] iio: gyro: adis16136: check ret val for non-zero vs less-than-zero Alexandru Ardelean
2019-11-03 10:15   ` Jonathan Cameron
2019-11-01  9:34 ` [PATCH 02/10] iio: imu: adis16400: " Alexandru Ardelean
2019-11-03 10:21   ` Jonathan Cameron
2019-11-04  7:40     ` Ardelean, Alexandru
2019-11-01  9:34 ` [PATCH 03/10] iio: imu: adis16460: " Alexandru Ardelean
2019-11-03 10:25   ` Jonathan Cameron
2019-11-01  9:34 ` [PATCH 04/10] iio: imu: adis16480: " Alexandru Ardelean
2019-11-03 10:27   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 05/10] iio: imu: adis: " Alexandru Ardelean
2019-11-03 10:31   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 06/10] iio: imu: adis16480: fix indentation of return statement Alexandru Ardelean
2019-11-03 10:35   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 07/10] iio: imu: adis16480: prefer `unsigned int` over `unsigned` Alexandru Ardelean
2019-11-03 10:36   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 08/10] iio: imu: adis16480: assign bias value only if operation succeeded Alexandru Ardelean
2019-11-03 10:41   ` Jonathan Cameron
2019-11-04  8:50     ` Ardelean, Alexandru
2019-11-01  9:35 ` [PATCH 09/10] iio: imu: adis: assign read val in debugfs hook only if op successful Alexandru Ardelean
2019-11-03 10:46   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 10/10] iio: imu: adis: assign value only if return code zero in read funcs Alexandru Ardelean
2019-11-03 10:49   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101093505.9408-1-alexandru.ardelean@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=dragos.bogdan@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).