linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: "Ramuthevar,Vadivel MuruganX" 
	<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: kbuild-all@lists.01.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org, broonie@kernel.org,
	vigneshr@ti.com, robh+dt@kernel.org, cheol.yong.kim@intel.com,
	qi-ming.wu@intel.com,
	Ramuthevar Vadivel Murugan 
	<vadivel.muruganx.ramuthevar@linux.intel.com>
Subject: [PATCH] spi: cadence-quadpsi: fix platform_get_irq.cocci warnings
Date: Fri, 1 Nov 2019 23:19:04 +0800	[thread overview]
Message-ID: <20191101151904.m2crt32kmn3gedba@4978f4969bb8> (raw)
In-Reply-To: <20191030081155.29947-3-vadivel.muruganx.ramuthevar@linux.intel.com>

From: kbuild test robot <lkp@intel.com>

drivers/spi/spi-cadence-quadspi.c:1181:2-9: line 1181 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 61e865acd941 ("spi: cadence-quadpsi: Add support for the Cadence QSPI controller")
CC: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Ramuthevar-Vadivel-MuruganX/spi-cadence-quadpsi-Add-support-for-the-Cadence-QSPI-controller/20191101-174846
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Please take the patch only if it's a positive warning. Thanks!

 spi-cadence-quadspi.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1178,7 +1178,6 @@ static int cadence_qspi_probe(struct pla
 
 	cqspi->irq = platform_get_irq(pdev, 0);
 	if (cqspi->irq < 0) {
-		dev_err(dev, "platform_get_irq failed.\n");
 		ret = -ENXIO;
 		goto err_irq;
 	}

  parent reply	other threads:[~2019-11-01 15:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  8:11 [PATCH v2 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2019-10-30  8:11 ` [PATCH v2 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar,Vadivel MuruganX
2019-11-05  4:30   ` Vignesh Raghavendra
2019-11-11  7:35     ` Ramuthevar, Vadivel MuruganX
2019-10-30  8:11 ` [PATCH v2 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2019-11-01 15:19   ` kbuild test robot
2019-11-01 15:19   ` kbuild test robot [this message]
2019-11-01 17:36   ` kbuild test robot
2019-11-01 17:36   ` [RFC PATCH] spi: cadence-quadpsi: cadence_qspi_init_timeout() can be static kbuild test robot
2019-11-07  5:44   ` [PATCH v2 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Vignesh Raghavendra
2019-11-11  7:32     ` Ramuthevar, Vadivel MuruganX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101151904.m2crt32kmn3gedba@4978f4969bb8 \
    --to=lkp@intel.com \
    --cc=broonie@kernel.org \
    --cc=cheol.yong.kim@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=qi-ming.wu@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).