linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com, jerome.pouiller@silabs.com,
	gregkh@linuxfoundation.com, Boqun.Feng@microsoft.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wfx: fix warning of using plain integer
Date: Sat, 2 Nov 2019 11:39:25 +0100	[thread overview]
Message-ID: <20191102103925.GA170933@kroah.com> (raw)
In-Reply-To: <20191102001457.23369-1-jbi.octave@gmail.com>

On Sat, Nov 02, 2019 at 12:14:57AM +0000, Jules Irenge wrote:
> Fix warning of using plain integer as NULL pointer.
> Issue reported by sparse tool.
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/wfx/queue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
> index ef3ee55cf621..5d29bce65f71 100644
> --- a/drivers/staging/wfx/queue.c
> +++ b/drivers/staging/wfx/queue.c
> @@ -565,7 +565,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
>  		}
>  
>  		if (ret)
> -			return 0;
> +			return NULL;
>  
>  		queue_num = queue - wdev->tx_queue;
>  
> -- 
> 2.21.0
> 

Please send this as part of a patch series, with your other changes to
this driver.

thanks,

greg k-h

      reply	other threads:[~2019-11-02 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02  0:14 [PATCH] staging: wfx: fix warning of using plain integer Jules Irenge
2019-11-02 10:39 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191102103925.GA170933@kroah.com \
    --to=greg@kroah.com \
    --cc=Boqun.Feng@microsoft.com \
    --cc=gregkh@linuxfoundation.com \
    --cc=jbi.octave@gmail.com \
    --cc=jerome.pouiller@silabs.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).