linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [GIT PULL 1/7] intel_th: gth: Fix the window switching sequence
Date: Sat, 2 Nov 2019 18:14:19 +0100	[thread overview]
Message-ID: <20191102171419.GA484428@kroah.com> (raw)
In-Reply-To: <20191028070651.9770-2-alexander.shishkin@linux.intel.com>

On Mon, Oct 28, 2019 at 09:06:45AM +0200, Alexander Shishkin wrote:
> Commit 8116db57cf16 ("intel_th: Add switch triggering support") added
> a trigger assertion of the CTS, but forgot to de-assert it at the end
> of the sequence. This results in window switches randomly not happening.
> 
> Fix that by de-asserting the trigger at the end of the window switch
> sequence.
> 
> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/hwtracing/intel_th/gth.c | 3 +++
>  1 file changed, 3 insertions(+)

Shouldn't this have a Fixes: tag and a cc: stable@ in it?

I can add it if you say it's ok to.

thanks,

greg k-h

  reply	other threads:[~2019-11-02 17:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28  7:06 [GIT PULL 0/7] intel_th: Fixes for v5.4 Alexander Shishkin
2019-10-28  7:06 ` [GIT PULL 1/7] intel_th: gth: Fix the window switching sequence Alexander Shishkin
2019-11-02 17:14   ` Greg Kroah-Hartman [this message]
2019-11-04  6:25     ` Alexander Shishkin
2019-11-04  6:35       ` Greg Kroah-Hartman
2019-11-04  6:54         ` Alexander Shishkin
2019-10-28  7:06 ` [GIT PULL 2/7] intel_th: msu: Fix an uninitialized mutex Alexander Shishkin
2019-11-02 17:14   ` Greg Kroah-Hartman
2019-11-04  6:27     ` Alexander Shishkin
2019-10-28  7:06 ` [GIT PULL 3/7] intel_th: msu: Fix missing allocation failure check on a kstrndup Alexander Shishkin
2019-10-28  7:06 ` [GIT PULL 4/7] intel_th: msu: Fix overflow in shift of an unsigned int Alexander Shishkin
2019-10-28  7:06 ` [GIT PULL 5/7] intel_th: msu: Fix possible memory leak in mode_store() Alexander Shishkin
2019-10-28  7:06 ` [GIT PULL 6/7] intel_th: pci: Add Comet Lake PCH support Alexander Shishkin
2019-10-28  7:06 ` [GIT PULL 7/7] intel_th: pci: Add Jasper " Alexander Shishkin
2019-11-04 14:02 ` [GIT PULL 0/7] intel_th: Fixes for v5.4 Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191102171419.GA484428@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).