From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
agross@kernel.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCH v3 11/11] arm64: dts: qcom: sc7180: Add pdc interrupt controller
Date: Sun, 3 Nov 2019 23:10:27 -0800 [thread overview]
Message-ID: <20191104071027.GD585@tuxbook-pro> (raw)
In-Reply-To: <c214110f-7620-8771-ef83-8a4fb1f8724f@codeaurora.org>
On Sun 03 Nov 22:56 PST 2019, Rajendra Nayak wrote:
>
>
> On 11/4/2019 12:03 PM, Bjorn Andersson wrote:
> > On Sun 03 Nov 22:17 PST 2019, Rajendra Nayak wrote:
> >
> > >
> > >
> > > On 10/31/2019 1:20 AM, Matthias Kaehlcke wrote:
> > > > On Tue, Oct 29, 2019 at 09:50:40AM -0700, Stephen Boyd wrote:
> > > > > Quoting Rajendra Nayak (2019-10-23 02:02:19)
> > > > > > From: Maulik Shah <mkshah@codeaurora.org>
> > > > > >
> > > > > > Add pdc interrupt controller for sc7180
> > > > > >
> > > > > > Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> > > > > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> > > > > > ---
> > > > > > v3:
> > > > > > Used the qcom,sdm845-pdc compatible for pdc node
> > > > >
> > > > > Everything else isn't doing the weird old compatible thing. Why not just
> > > > > add the new compatible and update the driver? I guess I'll have to go
> > > > > read the history.
> > > >
> > > > Marc Zyngier complained on v2 about the churn from adding compatible
> > > > strings for identical components, and I kinda see his point.
> > > >
> > > > I agree that using the 'sdm845' compatible string for sc7180 is odd too.
> > > > Maybe we should introduce SoC independent compatible strings for IP blocks
> > > > that are shared across multiple SoCs? If differentiation is needed SoC
> > > > specific strings can be added.
> > >
> > > Sure, I will perhaps add a qcom,pdc SoC independent compatible to avoid
> > > confusion.
> > >
> >
> > I agree,
> >
> > compatible = "qcom,sc7180-pdc", "qcom,pdc";
> >
> > is the way to go.
>
> I wasn't planning on adding a qcom,sc7180-pdc, but instead just use the
> qcom,pdc one for sc7180.
>
> >
> > Reusing qcom,sdm845-pdc would prevent us from tackling any unforeseen
> > issues/variations/erratas with one or the other platform in the future.
>
> That was the intention of adding qcom,sc7180-pdc in the first place,
> but Marc Zyngier was not happy with the churn, given there aren't really
> any variations or erratas that we know of.
>
Right, but by putting both compatibles in the dts and the generic one in
the driver we avoid the driver churn and we're future compatible.
And given that we haven't yet added the qcom,sdm845-pdc node to the
sdm845.dtsi we don't need to maintain the qcom,sdm845-pdc in the driver.
So switch qcom,sdm845-pdc to qcom,pdc in qcom-pdc.c.
Regards,
Bjorn
> >
> > Regards,
> > Bjorn
> >
> > >
> > > --
> > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> > > of Code Aurora Forum, hosted by The Linux Foundation
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-11-04 7:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:02 [PATCH v3 00/11] Add device tree support for sc7180 Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 01/11] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
2019-10-25 19:50 ` Rob Herring
2019-11-04 6:03 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 02/11] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
2019-10-29 16:49 ` Stephen Boyd
2019-11-04 6:15 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 03/11] dt-bindings: arm-smmu: update binding for qcom sc7180 SoC Rajendra Nayak
2019-10-25 19:51 ` Rob Herring
2019-11-04 6:04 ` Rajendra Nayak
2019-10-29 16:42 ` Stephen Boyd
2019-11-04 6:11 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 04/11] arm64: dts: sc7180: Add device node for apps_smmu Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 05/11] arm64: dts: qcom: sc7180: Add cmd_db reserved area Rajendra Nayak
2019-10-23 12:16 ` Sibi Sankar
2019-10-24 2:30 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 06/11] arm64: dts: qcom: sc7180: Add rpmh-rsc node Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 07/11] arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device Rajendra Nayak
2019-10-29 16:41 ` Stephen Boyd
2019-10-30 6:06 ` kgunda
2019-10-30 14:37 ` Stephen Boyd
2019-11-04 6:10 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 08/11] arm64: dts: qcom: pm6150: Add PM6150/PM6150L PMIC peripherals Rajendra Nayak
2019-10-29 16:38 ` Stephen Boyd
2019-10-30 7:06 ` kgunda
2019-10-30 14:37 ` Stephen Boyd
2019-10-23 9:02 ` [PATCH v3 09/11] arm64: dts: qcom: sc7180-idp: Add RPMh regulators Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 10/11] arm64: dts: qcom: SC7180: Add node for rpmhcc clock driver Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 11/11] arm64: dts: qcom: sc7180: Add pdc interrupt controller Rajendra Nayak
2019-10-25 19:47 ` Matthias Kaehlcke
2019-11-04 6:03 ` Rajendra Nayak
2019-10-29 16:50 ` Stephen Boyd
2019-10-30 19:50 ` Matthias Kaehlcke
2019-11-04 6:17 ` Rajendra Nayak
2019-11-04 6:33 ` Bjorn Andersson
2019-11-04 6:56 ` Rajendra Nayak
2019-11-04 7:10 ` Bjorn Andersson [this message]
2019-11-05 0:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104071027.GD585@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).