linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/11] ARM: dts: imx6ul-kontron-n6x1x-s: Disable the snvs-poweroff driver
Date: Mon, 4 Nov 2019 20:45:55 +0800	[thread overview]
Message-ID: <20191104124553.GY24620@dragon> (raw)
In-Reply-To: <7da30a17-d16c-3cde-12a8-430ff3eec692@kontron.de>

On Mon, Nov 04, 2019 at 11:18:19AM +0000, Schrempf Frieder wrote:
> On 04.11.19 09:06, Frieder Schrempf wrote:
> > Hi Shawn,
> > 
> > On 04.11.19 08:43, Shawn Guo wrote:
> >> On Thu, Oct 31, 2019 at 02:24:27PM +0000, Schrempf Frieder wrote:
> >>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>>
> >>> The snvs-poweroff driver can power off the system by pulling the
> >>> PMIC_ON_REQ signal low, to let the PMIC disable the power.
> >>> The Kontron SoMs do not have this signal connected, so let's remove
> >>> the node.
> >>>
> >>> This seems to fix a real issue when the signal is asserted at
> >>> poweroff, but not actually causing the power to turn off. It was
> >>> observed, that in this case the system would not shut down properly.
> >>
> >> I do not quite follow on this.  How does disabling snvs_poweroff fix the
> >> issue?  The root cause of system not shut down properly seems to be that
> >> PMIC doesn't shut down power.  This looks like a clean-up rather than
> >> bug fix.
> > 
> > I don't know the exact reasons, but we had issues on these boards when 
> > doing a "poweroff". The kernel would print something like the log below.
> > Disabling the snvs-poweroff solved this.
> > 
> > But note that this has last been reproduced on v4.14. So I'm not sure if 
> > this is still a problem with the current kernel.
> > 
> > #######
> > reboot: Power down
> > Unable to poweroff system
> > 
> > ====================================
> > WARNING: halt/675 still has locks held!
> > 4.14.104-exceet #1 Not tainted
> > ------------------------------------
> > 1 lock held by halt/675:
> >   #0:  (reboot_mutex){+.+.}, at: [<c0145a98>] SyS_reboot+0x14c/0x1dc
> > #######
> > 
> >>
> >>>
> >>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron 
> >>> i.MX6UL N6310 SoM and boards")
> >>
> >> If you think this is really a bug fix, it should be applied to the file
> >> before renaming rather than the one after renaming.
> > 
> > I will try to reproduce the issue with the current kernel and depending 
> > on the results either drop the Fixes tag or move the patch before the 
> > renaming.
> 
> I just tried this with 5.4-rc5 and the issue persists. When 
> snvs-poweroff is enabled without the hardware actually being able to 
> power down via PMIC I get a locking WARNING from the kernel. Probably 
> because the system is still running, when it's already supposed to be 
> shut down by the PMIC.

I still do not get it.  Are you saying that with snvs-poweroff being
disabled, your system is now able to be shut down properly by PMIC?

Shawn

> 
> So this fixes a real problem and therefore I will keep the Fixes tag and 
> move the patch to the proper place in this series.

  reply	other threads:[~2019-11-04 12:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 14:23 [PATCH v3 00/11] Add support for more Kontron i.MX6UL/ULL SoMs and boards Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 01/11] ARM: dts: imx6ul-kontron-n6310: Move common SoM nodes to a separate file Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 02/11] ARM: dts: Add support for two more Kontron SoMs N6311 and N6411 Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 03/11] ARM: dts: imx6ul-kontron-n6310-s: Move common nodes to a separate file Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 04/11] ARM: dts: Add support for two more Kontron evalkit boards 'N6311 S' and 'N6411 S' Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 05/11] ARM: dts: imx6ul-kontron-n6x1x: Add 'chosen' node with 'stdout-path' Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 06/11] ARM: dts: imx6ul-kontron-n6x1x-s: Specify bus-width for SD card and eMMC Schrempf Frieder
2019-11-04  7:29   ` Shawn Guo
2019-11-04  7:40     ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 07/11] ARM: dts: imx6ul-kontron-n6x1x-s: Add vbus-supply and overcurrent polarity to usb nodes Schrempf Frieder
2019-11-04  7:31   ` Shawn Guo
2019-11-04  7:53     ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 08/11] ARM: dts: imx6ul-kontron-n6x1x-s: Remove an obsolete comment and fix indentation Schrempf Frieder
2019-11-04  7:33   ` Shawn Guo
2019-11-04  7:53     ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 09/11] ARM: dts: imx6ul-kontron-n6x1x-s: Disable the snvs-poweroff driver Schrempf Frieder
2019-11-04  7:43   ` Shawn Guo
2019-11-04  8:06     ` Schrempf Frieder
2019-11-04 11:18       ` Schrempf Frieder
2019-11-04 12:45         ` Shawn Guo [this message]
2019-11-04 13:14           ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 10/11] dt-bindings: arm: fsl: Add more Kontron i.MX6UL/ULL compatibles Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 11/11] MAINTAINERS: Add an entry for Kontron Electronics ARM board support Schrempf Frieder
2019-11-04  7:45   ` Shawn Guo
2019-11-04  8:16     ` Schrempf Frieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104124553.GY24620@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).