From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Wei Zhao <wallyzhao@gmail.com>
Cc: kernel test robot <rong.a.chen@intel.com>,
vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, wally.zhao@nokia-sbell.com,
lkp@lists.01.org
Subject: Re: [sctp] 327fecdaf3: BUG:kernel_NULL_pointer_dereference,address
Date: Mon, 4 Nov 2019 11:49:09 -0300 [thread overview]
Message-ID: <20191104144909.GA15842@localhost.localdomain> (raw)
In-Reply-To: <CAFRmqq6vNg5sBYp7voT4SoVR+i+L8fDqUUZOF68cRdcKkQcZmw@mail.gmail.com>
On Mon, Nov 04, 2019 at 10:14:00PM +0800, Wei Zhao wrote:
> On 11/4/19, Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote:
> > On Mon, Nov 04, 2019 at 04:46:35PM +0800, kernel test robot wrote:
> >> [ 35.312661] BUG: kernel NULL pointer dereference, address:
> >> 00000000000005d8
> >> [ 35.316225] #PF: supervisor read access in kernel mode
> >> [ 35.319178] #PF: error_code(0x0000) - not-present page
> >> [ 35.322078] PGD 800000021b569067 P4D 800000021b569067 PUD 21b688067 PMD
> >> 0
> >> [ 35.325629] Oops: 0000 [#1] SMP PTI
> >> [ 35.327965] CPU: 0 PID: 3148 Comm: trinity-c5 Not tainted
> >> 5.4.0-rc3-01107-g327fecdaf39ab #12
> >> [ 35.332863] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
> >> 1.10.2-1 04/01/2014
> >> [ 35.337932] RIP: 0010:sctp_packet_transmit+0x767/0x822
> >
> > Right, as asoc can be NULL by then. (per the check on it a few lines
> > before the change here).
>
> Yes, apologize for missing the NULL check (Actually I realized some
> further check is need to correctly identify the first in flight
> packet, as outstanding_bytes has already been increased by this first
> in flight packet itself before getting into sctp_packet_transmit).
>
> Anyway, I think I do not need further action, as the patch is anyway
> not going to be merged, the 0day robot picks up the patch from the
> mail list directly instead of git repo, right?
That's my understanding as well. I double checked and the patch wasn't
applied by Dave, so we're good.
Thanks,
Marcelo
prev parent reply other threads:[~2019-11-04 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 16:07 [PATCH] sctp: set ooo_okay properly for Transmit Packet Steering Wally Zhao
2019-10-30 13:24 ` Marcelo Ricardo Leitner
2019-10-30 15:54 ` Wei Zhao
2019-10-30 18:35 ` Marcelo Ricardo Leitner
2019-10-30 19:03 ` Eric Dumazet
2019-10-31 1:11 ` Wei Zhao
2019-11-04 8:46 ` [sctp] 327fecdaf3: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2019-11-04 13:25 ` Marcelo Ricardo Leitner
2019-11-04 14:14 ` Wei Zhao
2019-11-04 14:49 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104144909.GA15842@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rong.a.chen@intel.com \
--cc=vyasevich@gmail.com \
--cc=wally.zhao@nokia-sbell.com \
--cc=wallyzhao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).