From: Christoph Hellwig <hch@lst.de>
To: Charles Machalow <csm10495@gmail.com>
Cc: Marta Rybczynska <mrybczyn@kalray.eu>,
Christoph Hellwig <hch@lst.de>,
linux-nvme <linux-nvme@lists.infradead.org>,
kbusch <kbusch@kernel.org>, axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.
Date: Mon, 4 Nov 2019 16:30:27 +0100 [thread overview]
Message-ID: <20191104153027.GC17050@lst.de> (raw)
In-Reply-To: <CANSCoS9A1XY4DzdBwGU4+oT-uKvpohxhyWxdJ1ySJ6QKv6moKw@mail.gmail.com>
On Mon, Nov 04, 2019 at 07:20:43AM -0800, Charles Machalow wrote:
> The thing with that structure is if you use it with the old IOCTL, the
> result will go into rsvd2 instead of the first 32 bits of result.
But if you use the old ioctls on the new structure you can at least
expect that. And with the added explicit padding it will at least
do the right thing on 32-bit x86 as well.
prev parent reply other threads:[~2019-11-04 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 5:03 [PATCH] nvme: change nvme_passthru_cmd64's result field Charles Machalow
2019-10-31 13:39 ` Christoph Hellwig
[not found] ` <CANSCoS8rN6g7u6iG4SRTcXjdj68cbimvX1n1Ex+FBAkhAAivJA@mail.gmail.com>
2019-10-31 13:59 ` Christoph Hellwig
2019-10-31 15:39 ` Charles Machalow
2019-10-31 13:59 ` Charles Machalow
2019-11-04 14:34 ` Marta Rybczynska
2019-11-04 14:51 ` Charles Machalow
2019-11-04 14:56 ` Marta Rybczynska
2019-11-04 15:01 ` Keith Busch
2019-11-04 15:29 ` Christoph Hellwig
2019-11-04 15:32 ` Keith Busch
2019-11-04 15:01 ` Charles Machalow
2019-11-04 15:16 ` Marta Rybczynska
2019-11-04 15:20 ` Charles Machalow
2019-11-04 15:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104153027.GC17050@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=csm10495@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mrybczyn@kalray.eu \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).