From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB: mlx5: no need to check return value of debugfs_create functions
Date: Mon, 4 Nov 2019 22:08:44 +0100 [thread overview]
Message-ID: <20191104210844.GB2460177@kroah.com> (raw)
In-Reply-To: <20191104205914.GI30938@ziepe.ca>
On Mon, Nov 04, 2019 at 04:59:14PM -0400, Jason Gunthorpe wrote:
> On Mon, Nov 04, 2019 at 08:41:41AM +0100, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Leon Romanovsky <leon@kernel.org>
> > Cc: Doug Ledford <dledford@redhat.com>
> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > drivers/infiniband/hw/mlx5/main.c | 62 +++++++---------------------
> > drivers/infiniband/hw/mlx5/mlx5_ib.h | 9 +---
> > 2 files changed, 16 insertions(+), 55 deletions(-)
> >
> > Note, I kind of need to take this through my tree now as I broke the
> > build due to me changing the use of debugfs_create_atomic_t() in my
> > tree and not noticing this being used here. Sorry about that, any
> > objections?
>
> I think it is fine, I don't forsee conflicts here at this point.
Thanks!
> To be clear, the build is broken in your tree and in linux-next?
Yeah, my fault :(
> > And 0-day seems really broken to have missed this for the past months,
> > ugh, I need to stop relying on it...
>
> Yes, I've noticed it missing a lot of stuff now too. Not sure why
It is very hit-or-miss these days :(
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-04 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 7:41 [PATCH] IB: mlx5: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-11-04 20:59 ` Jason Gunthorpe
2019-11-04 21:08 ` Greg Kroah-Hartman [this message]
2019-11-05 0:48 ` Mark Bloch
2019-11-05 7:24 ` Greg Kroah-Hartman
2019-11-05 14:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104210844.GB2460177@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).