From: Rob Herring <robh@kernel.org>
To: Manish Narani <manish.narani@xilinx.com>
Cc: ulf.hansson@linaro.org, mark.rutland@arm.com,
adrian.hunter@intel.com, michal.simek@xilinx.com,
jolly.shah@xilinx.com, nava.manne@xilinx.com,
rajan.vaja@xilinx.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, git@xilinx.com
Subject: Re: [PATCH v5 4/8] dt-bindings: mmc: Add optional generic properties for mmc
Date: Mon, 4 Nov 2019 17:14:27 -0600 [thread overview]
Message-ID: <20191104231427.GA7606@bogus> (raw)
In-Reply-To: <1572588353-110682-5-git-send-email-manish.narani@xilinx.com>
On Fri, Nov 01, 2019 at 11:35:49AM +0530, Manish Narani wrote:
> Add optional properties for mmc hosts which are used to set clk delays
> for different speed modes in the controller.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> .../bindings/mmc/mmc-controller.yaml | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 080754e0ef35..87a83d966851 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -212,6 +212,98 @@ properties:
> description:
> eMMC HS400 enhanced strobe mode is supported
>
> + # Below mentioned are the clock (phase) delays which are to be configured
> + # in the controller while switching to particular speed mode. The range
> + # of values are 0 to 359 degrees.
> +
> + clk-phase-legacy:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for Legacy Mode.
> +
> + clk-phase-mmc-hs:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair degrees for MMC HS.
> +
> + clk-phase-sd-hs:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for SD HS.
> +
> + clk-phase-uhs-sdr12:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for SDR12.
> +
> + clk-phase-uhs-sdr25:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for SDR25.
> +
> + clk-phase-uhs-sdr50:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for SDR50.
> +
> + clk-phase-uhs-sdr104:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for SDR104.
> +
> + clk-phase-uhs-ddr50:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for SD DDR50.
> +
> + clk-phase-mmc-ddr52:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for MMC DDR52.
> +
> + clk-phase-mmc-hs200:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for MMC HS200.
> +
> + clk-phase-mmc-hs400:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 0
> + - maximum: 359
> + description:
> + Input/Output Clock Delay pair in degrees for MMC HS400.
This can be condensed into:
patternProperties:
"^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-(sdr(12|25|50|104)|ddr50))$":
Or if you want to divide them between SD and MMC ones, that would be
fine for me.
Rob
next prev parent reply other threads:[~2019-11-04 23:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 6:05 [PATCH v5 0/8] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling Manish Narani
2019-11-01 6:05 ` [PATCH v5 1/8] mmc: sdhci-of-arasan: Separate out clk related data to another structure Manish Narani
2019-11-01 6:05 ` [PATCH v5 2/8] dt-bindings: mmc: arasan: Update Documentation for the input clock Manish Narani
2019-11-01 6:05 ` [PATCH v5 3/8] mmc: sdhci-of-arasan: Add sampling clock for a phy to use Manish Narani
2019-11-01 6:05 ` [PATCH v5 4/8] dt-bindings: mmc: Add optional generic properties for mmc Manish Narani
2019-11-04 23:14 ` Rob Herring [this message]
2019-11-11 10:07 ` Manish Narani
2019-11-18 3:55 ` Manish Narani
2019-11-18 14:44 ` Rob Herring
2019-11-01 6:05 ` [PATCH v5 5/8] mmc: sdhci-of-arasan: Add support to set clock phase delays for SD Manish Narani
2019-11-01 6:05 ` [PATCH v5 6/8] firmware: xilinx: Add SDIO Tap Delay nodes Manish Narani
2019-11-01 6:05 ` [PATCH v5 7/8] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller Manish Narani
2019-11-01 6:05 ` [PATCH v5 8/8] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104231427.GA7606@bogus \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=jolly.shah@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).